Bug 15960 - Use Font Awesome icons for classification filing rule deletion error
Summary: Use Font Awesome icons for classification filing rule deletion error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/classsources.pl?o...
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-02 16:52 UTC by Owen Leonard
Modified: 2017-06-14 22:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15960 - Use Font Awesome icons for classification filing rule deletion error (2.03 KB, patch)
2016-03-02 16:58 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15960: Use Font Awesome icons for classification filing rule deletion error (2.08 KB, patch)
2016-03-03 15:28 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15960: Use Font Awesome icons for classification filing rule deletion error (2.13 KB, patch)
2016-03-10 11:02 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-02 16:52:43 UTC
I missed this one in my previous patch modifying classsources.tt. When you try to delete a filing rule and it is in use a dialog is shown explaining that deletion isn't possible.
Comment 1 Owen Leonard 2016-03-02 16:58:54 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-03 15:28:42 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:02:07 UTC
Created attachment 48937 [details] [review]
Bug 15960: Use Font Awesome icons for classification filing rule deletion error

When deletion of a classification filing rule is impossible, the dialog
saying so should be styled with Font Awesome icons. This patch corrects
this omission from the patch for Bug 15785.

Also changed: The dialog is now an "alert" style dialog instead of a
"message" one.

To test, apply the patch and go to Administration -> Classification
sources.

- Locate a classification filing rule which is in use by a
  classification source.
- Click the "Delete" link for that rule and verify that the resulting
  dialog is correctly styled.
- Click the "OK" button and confirm that you are correctly redirected.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertise

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:35:24 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!