Bug 15963 - Use Font Awesome icons for confirmation after deleting MARC tag
Summary: Use Font Awesome icons for confirmation after deleting MARC tag
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/marctagstructure.pl
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-02 19:24 UTC by Owen Leonard
Modified: 2017-06-14 22:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15963 - Use Font Awesome icons for confirmation after deleting MARC tag (1.51 KB, patch)
2016-03-02 19:33 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15963: Use Font Awesome icons for confirmation after deleting MARC tag (1.56 KB, patch)
2016-03-03 15:43 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15963: Use Font Awesome icons for confirmation after deleting MARC tag (1.61 KB, patch)
2016-03-10 11:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-02 19:24:00 UTC
After deleting a MARC tag the user is presented with a confirmation dialog which should use Font Awesome.
Comment 1 Owen Leonard 2016-03-02 19:33:45 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-03 15:43:10 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:23:19 UTC
Created attachment 48941 [details] [review]
Bug 15963: Use Font Awesome icons for confirmation after deleting MARC tag

This patch revises the dialog which appears after you have deleted a
MARC tag.

To test, apply the patch and go to Administration -> MARC frameworks ->
MARC sturcture -> Delete.

- Confirm that you want to delete a MARC tag.
- Verify that the confirmation dialog you are shown is styled correctly.
- Verify that clicking "OK" redirects you to the right place.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:34:02 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!