Bug 15980 - Use Font Awesome icons in subscription frequency deletion confirmation dialog
Summary: Use Font Awesome icons in subscription frequency deletion confirmation dialog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/serials/subscription-fr...
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-04 16:30 UTC by Owen Leonard
Modified: 2017-06-14 22:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15980 - Use Font Awesome icons in subscription frequency deletion confirmation dialog (2.85 KB, patch)
2016-03-04 16:47 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog (2.90 KB, patch)
2016-03-07 14:43 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog (2.96 KB, patch)
2016-03-10 11:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-04 16:30:32 UTC
If you try to delete a subscription frequency which is in use by an existing subscription you are presented with a confirmation dialog. This dialog should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-04 16:47:43 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-03-07 14:43:06 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 11:30:55 UTC
Created attachment 48943 [details] [review]
Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog

If you try to delete a subscription frequency which is in use by an
existing subscription you will be shown a confirmation dialog. This
dialog should use Font Awesome icons.

Other minor changes:

- Added "action" attributes to <form>s to fix validation errors.
- Added "alert" class to confirmation dialog so that it is correctly
  styled.

To test, apply the patch and go to Serials -> Frequencies.

- Click "Delete" on a frequency which is in use by a subscription.
- Verify that the confirmation dialog is styled correctly.
- Test that the "No, do not delete" button works correctly.
- Test that the "Yes, delete" button deletes the correct frequency.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-03-12 23:30:34 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!