Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991, Bug 15992
Created attachment 48720 [details] [review] Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT
Created attachment 48826 [details] [review] Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
Created attachment 48850 [details] [review] Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note that the deletion does not work, I have fixed that yesterday on bug 15962. The 2 patches do not conflict.
Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons.
Created attachment 48903 [details] [review] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT
Created attachment 49043 [details] [review] [SIGNED-OFF] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 49044 [details] [review] Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths.
Created attachment 49065 [details] [review] [SIGNED-OFF] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> https://bugs.koha-community.org/show_bug.cgi?id=15593
Created attachment 49066 [details] [review] [SIGNED-OFF] Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> https://bugs.koha-community.org/show_bug.cgi?id=15593
Created attachment 49119 [details] [review] Bug 15993: Making currency actions buttons To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49120 [details] [review] Bug 15993 [Follow-up] Making currency actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and go to Administration -> Currencies and exchange rates. In the table of currencies, confirm that the "Edit" and "Delete" buttons are not stacked one on top of the other even at narrow browser window widths. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!