Created attachment 48979 [details] [review] Bug 16048: Making notices actions buttons To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT
Created attachment 48980 [details] [review] Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT
Aleisha, it is better to define a class name for the td and set a style in the css file: Something like: <td class="actions"> .actions { white-space: nowrap; }
Created attachment 49007 [details] [review] [SIGNED-OFF] Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have a couple of corrections in a follow-up.
Created attachment 49008 [details] [review] Bug 16048 [Follow-up] Making notices actions buttons This followup adds a "td.actions" style with "white-space:nowrap" and replaces the inline styles. Also modified is the way non-sorting table columns are defined. This corrects a problem with non-sortable columns introducted by the previous patch's column changes. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Notices and confirm that even at narrow browser widths the "Edit" and "Delete" buttons stay side by side. - Confirm that all columns are sortable except "Copy notice" and "Actions."
Created attachment 49010 [details] [review] Bug 16048: Making notices actions buttons EDIT: Adding no wrap class to Actions column for when libraries with longer names mess up formatting To test: 1) Go to Tools -> Notices and slips (tools/letter.pl) 2) Confirm that all actions (Copy, Edit and Delete) now show as font awesome buttons and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I have a couple of corrections in a follow-up. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49011 [details] [review] Bug 16048 [Follow-up] Making notices actions buttons This followup adds a "td.actions" style with "white-space:nowrap" and replaces the inline styles. Also modified is the way non-sorting table columns are defined. This corrects a problem with non-sortable columns introducted by the previous patch's column changes. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Notices and confirm that even at narrow browser widths the "Edit" and "Delete" buttons stay side by side. - Confirm that all columns are sortable except "Copy notice" and "Actions." Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks