Styling the actions (View, Add to basket) as font awesome buttons
Created attachment 48916 [details] [review] Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT
Created attachment 48923 [details] [review] Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(Same as bug 15992 comment 6) Aleisha, seems to be the common way to "named" the actions column: % git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485
(In reply to Jonathan Druart from comment #3) > (Same as bug 15992 comment 6) > Aleisha, > seems to be the common way to "named" the actions column: > > % git grep '<th> </th>' **/*.tt|wc > 127 339 13098 > % git grep '<th>Actions</th>' **/*.tt|wc > 15 33 1485 Same reply as bug 15992: I think it tends to be that when the actions have been moved into a drop down menu, the column gets named because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions.
Should not we apply the white-space: nowrap style for the actions td (see bug 16048 comment2)?
Created attachment 49012 [details] [review] Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower.
Created attachment 49068 [details] [review] [SIGNED-OFF] Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Created attachment 49069 [details] [review] [SIGNED-OFF] Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 49115 [details] [review] Bug 16036: Making basket actions buttons To test: 1) Go to Acqui -> do a vendor search 2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as expected Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 49116 [details] [review] Bug 16036 [Follow-up] Making basket actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. To test, apply the patch for Bug 16048 and search for a vendor in Acquisitions which has at least one open basket. Confirm that the "View" and "Add to basket" buttons look correct and do not wrap when you make your browser window narrower. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!