Bug 16036 - Making basket actions buttons
Summary: Making basket actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-10 03:35 UTC by Aleisha Amohia
Modified: 2017-06-14 22:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16036: Making basket actions buttons (2.64 KB, patch)
2016-03-10 03:36 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16036: Making basket actions buttons (2.78 KB, patch)
2016-03-10 06:02 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 16036 [Follow-up] Making basket actions buttons (1.73 KB, patch)
2016-03-11 13:34 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16036: Making basket actions buttons (2.80 KB, patch)
2016-03-13 21:30 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16036 [Follow-up] Making basket actions buttons (1.76 KB, patch)
2016-03-13 21:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16036: Making basket actions buttons (2.85 KB, patch)
2016-03-14 16:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16036 [Follow-up] Making basket actions buttons (1.81 KB, patch)
2016-03-14 16:25 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-10 03:35:12 UTC
Styling the actions (View, Add to basket) as font awesome buttons
Comment 1 Aleisha Amohia 2016-03-10 03:36:35 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-03-10 06:02:49 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-10 12:20:12 UTC
(Same as bug 15992 comment 6)
Aleisha,
  seems to be the common way to "named" the actions column:

% git grep '<th>&nbsp;</th>' **/*.tt|wc
    127     339   13098
% git grep '<th>Actions</th>' **/*.tt|wc
     15      33    1485
Comment 4 Aleisha Amohia 2016-03-10 21:13:57 UTC
(In reply to Jonathan Druart from comment #3)
> (Same as bug 15992 comment 6)
> Aleisha,
> &nbsp; seems to be the common way to "named" the actions column:
> 
> % git grep '<th>&nbsp;</th>' **/*.tt|wc
>     127     339   13098
> % git grep '<th>Actions</th>' **/*.tt|wc
>      15      33    1485

Same reply as bug 15992:
I think it tends to be that when the actions have been moved into a drop down menu, the column gets named &nbsp; because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions.
Comment 5 Jonathan Druart 2016-03-11 07:41:49 UTC
Should not we apply the white-space: nowrap style for the actions td (see bug 16048 comment2)?
Comment 6 Owen Leonard 2016-03-11 13:34:15 UTC Comment hidden (obsolete)
Comment 7 Aleisha Amohia 2016-03-13 21:30:43 UTC Comment hidden (obsolete)
Comment 8 Aleisha Amohia 2016-03-13 21:32:17 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-03-14 16:25:31 UTC
Created attachment 49115 [details] [review]
Bug 16036: Making basket actions buttons

To test:
1) Go to Acqui -> do a vendor search
2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as
   expected

Sponsored-by: Catalyst IT
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2016-03-14 16:25:34 UTC
Created attachment 49116 [details] [review]
Bug 16036 [Follow-up] Making basket actions buttons

This trivial follow-up adds an "actions" class to the table cell
containing the new buttons. In conjunction with the style update in Bug
16048, this will prevent the buttons from wrapping at narrow browser
window widths.

To test, apply the patch for Bug 16048 and search for a vendor in
Acquisitions which has at least one open basket.

Confirm that the "View" and "Add to basket" buttons look correct and do
not wrap when you make your browser window narrower.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Brendan Gallagher 2016-03-18 07:08:05 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!