Bug 16042 - Missing closing quote in checkin template
Summary: Missing closing quote in checkin template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/circ/returns.pl
Keywords:
Depends on: 15821
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-10 15:04 UTC by Owen Leonard
Modified: 2016-12-05 21:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16042 - Missing closing quote in checkin template (1.99 KB, patch)
2016-03-10 15:18 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 16042 - Missing closing quote in checkin template (2.01 KB, patch)
2016-03-10 15:49 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-10 15:04:04 UTC 
A missing closing quotation mark in the checkin template is breaking the display when multiple messages are displayed upon return.
Comment 1 Owen Leonard 2016-03-10 15:18:29 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2016-03-10 15:49:52 UTC 
Created attachment 48967 [details] [review]
Bug 16042 - Missing closing quote in checkin template

A missing quotation mark breaks the display of multiple messages during
checking. This patch adds the missing quote.

To test, apply the patch and locate an item which is on hold and is not
checked out.

 - Check in the item.
 - Confirm that both the hold notification and the "Not checked out"
   alert look correct.
 - For extra credit, validate the page and confirm that there are no
   errors related to broken markup.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Brendan Gallagher 2016-03-11 15:26:41 UTC 
Pushed to Master - Should be in the May 2016 release.  Thanks
Comment 4 Julian Maurice 2016-03-14 09:34:29 UTC 
Does not concern stable versions, changed status to RESOLVED