Bug 15821 - Use Font Awesome icons in confirmation dialogs - Circulation
Summary: Use Font Awesome icons in confirmation dialogs - Circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
: 14171 15681 (view as bug list)
Depends on: 15785
Blocks: 16042 16215
  Show dependency treegraph
 
Reported: 2016-02-15 20:58 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation (18.82 KB, patch)
2016-02-15 22:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation (18.00 KB, patch)
2016-02-23 21:00 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation (18.00 KB, patch)
2016-02-24 19:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation (18.02 KB, patch)
2016-02-29 10:39 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-02-15 20:58:39 UTC
Building on from Bug 15785
Comment 1 Aleisha Amohia 2016-02-15 22:16:09 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-02-16 15:41:01 UTC
Everything looks good except these issues:

 - The "Cancel checkout and place hold" button isn't working for me. Nothing happens when I click it.

- On the batch checkout screen, I don't think it is consistent to add an icon to that button. At this time we don't have a standard of adding icons to every submit button.

- Missing closing bracket on line 52 of renew.tt:

<button type="submit" class="approve"><i class="fa fa-check"</i> Override limit and renew</button>
Comment 3 Aleisha Amohia 2016-02-23 21:00:41 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2016-02-24 19:24:31 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-02-29 10:39:54 UTC
Created attachment 48438 [details] [review]
Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation

To test, apply the patch and test deletion in the following cases. Test
both confirmation and cancel actions.

Circulation -> Check out
   -> An item that is checked out by someone else
   -> An item that is on hold to someone else
   -> To a patron that has more than noisuescharge in fines (Allow
      AllowFineOverride syspref)
   -> To a patron that has reached the max amount of checkouts (Allow
      AllowTooManyOverride syspref)
   -> To a patron that has more than noissuescharge in fines (Allow
      AllowFineOverride syspref and set noissuescharge syspref)
   -> Renew -> An item that is on hold to someone else
   -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref)
   -> An item that is not checked out by anyone
   -> Check in -> An item that is in transit to another branch

And look for other confirmation dialogs and check if I've missed any

Sponsored-by: Catalyst IT

EDIT: Made changes from Comment 2
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-02-29 10:40:54 UTC
note that this patch also changes the wording "Click here to place a hold for " to "Cancel checkout and place a hold for".
Comment 7 Jonathan Druart 2016-02-29 10:41:12 UTC
*** Bug 15681 has been marked as a duplicate of this bug. ***
Comment 8 Brendan Gallagher 2016-03-02 03:53:27 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks
Comment 9 Owen Leonard 2016-03-22 18:14:41 UTC
*** Bug 14171 has been marked as a duplicate of this bug. ***