Bug 16082 - Empty patron detail page is displayed if the patron does not exist - circulation.pl
Summary: Empty patron detail page is displayed if the patron does not exist - circulat...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 16073 16240
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-16 10:06 UTC by Jonathan Druart
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl (7.02 KB, patch)
2016-03-16 10:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl (7.15 KB, patch)
2016-03-16 10:41 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl (7.22 KB, patch)
2016-03-20 16:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-16 10:06:01 UTC
On circulation.pl, an empty patron detail page is displayed if the patron does not exist.
A friendly message should be displayed instead.
Comment 1 Jonathan Druart 2016-03-16 10:06:28 UTC
Patches from bug 16073 must be applied before.
Comment 2 Jonathan Druart 2016-03-16 10:11:38 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-03-16 10:41:42 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-03-20 16:03:28 UTC
Created attachment 49332 [details] [review]
[PASSED QA] Bug 16082: Display a friendly "patron does not exist" message if that's the case - circulation.pl

The major part of pages you can access from a patron detail page (menu)
does not take into consideration the 'patron does not exist' case.
If the borrowernumber is linked to a deleted patron, a friendly message
should be displayed instead of an empty patron detail page.

Test plan:
Go on circ/circulation.pl?borrowernumber=424242
and   circ/circulation.pl?borrowernumber=424242&batch=1
Notice the difference before and after this patch

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-03-21 16:58:54 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 6 Julian Maurice 2016-04-01 13:13:03 UTC
Patch pushed to 3.22.x, will be in 3.22.6