Bug 16240 - Regression: Bug 16082 causes message to be displayed even when no borrowernumber is passed
Summary: Regression: Bug 16082 causes message to be displayed even when no borrowernum...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16082
  Show dependency treegraph
 
Reported: 2016-04-11 15:18 UTC by Owen Leonard
Modified: 2019-06-27 09:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed (1.33 KB, patch)
2016-04-12 08:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed (1.47 KB, patch)
2016-04-12 14:08 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed (1.53 KB, patch)
2016-04-13 22:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-11 15:18:36 UTC
Bug 16082 made this change: 

"On circulation.pl, an empty patron detail page is displayed if the patron does not exist. A friendly message should be displayed instead."

However, now if you navigate directly to /cgi-bin/koha/circ/circulation.pl you will see a message, "This patron does not exist."

The message should only be displayed if a borrowernumber or card number was passed and not found.
Comment 1 Jonathan Druart 2016-04-12 08:31:55 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-12 14:08:39 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-13 22:23:58 UTC
Created attachment 50217 [details] [review]
[PASSED QA] Bug 16240: (follow-up for 16082) Do not display message if no borrowernumber passed

"This patron does not exist" message should not be displayed on the
"Checkouts home page". The message should only be displayed if the
borrowernumber parameter is passed.

Test plan:
Go on circ/circulation.pl
=> No message
Go on circ/circulation.pl?borrowernumber=424242
=> You should see the message

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-04-20 17:09:47 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-04-21 07:40:58 UTC
Patch pushed to 3.22.x, will be in 3.22.6