Found when signed-off bug 16091. Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages>
Created attachment 49280 [details] [review] Bug 16092: Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected
Created attachment 49281 [details] [review] Bug 16092: Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch>
Still applies without DUPLICATE BUG 16091, the patch applies in both ways applying on top 16047 only or applying 16047 and 16015 on top. >Using index info to reconstruct a base tree... >Falling back to patching base and 3-way merge... >Auto-merging admin/branches.pl
Sorry, but this no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16092: Introduce the Font Awesome icons when delete a branch category. fatal: sha1 information is lacking or useless (admin/branches.pl). The patch code also seems to include a lot more than the Font Awesome icon change - please correct bug title to reflect this :)
Created attachment 49639 [details] [review] Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4
Created attachment 49640 [details] [review] Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4
Created attachment 49733 [details] [review] Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 release. Thanks!