Bug 15784 - Library deletion warning is incorrectly styled
Summary: Library deletion warning is incorrectly styled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/branches.pl
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-10 16:22 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15784 - Library deletion warning is incorrectly styled (2.44 KB, patch)
2016-02-10 16:31 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled (2.49 KB, patch)
2016-02-10 19:08 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15784 [Revised] Library deletion warning is incorrectly styled (2.63 KB, patch)
2016-02-12 13:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15784 [Revised] Library deletion warning is incorrectly styled (2.76 KB, patch)
2016-02-12 14:14 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15784: Library deletion warning is incorrectly styled (2.74 KB, patch)
2016-02-12 15:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15784: Library deletion warning is incorrectly styled (2.82 KB, patch)
2016-02-12 15:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
[3.22.x] Bug 15784: Library deletion warning is incorrectly styled (2.28 KB, patch)
2016-03-07 11:20 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-02-10 16:22:00 UTC
When deleting a library in Administration ->  Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>.
Comment 1 Owen Leonard 2016-02-10 16:31:00 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-02-10 19:08:33 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-02-12 13:52:58 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-02-12 14:14:11 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-02-12 15:11:09 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-02-12 15:11:29 UTC
Created attachment 47989 [details] [review]
Bug 15784: Library deletion warning is incorrectly styled

When deleting a library in Administration ->  Libraries and groups, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.

Revised to include Font Awesome icons. Depends on Bug 15785.

To test, apply the patch and go to Administration -> Libraries and
groups.

- Try deleting a library. The confirmation box should have the standard
  "dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
  correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Buttons display as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Brendan Gallagher 2016-02-24 01:51:11 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks
Comment 8 Julian Maurice 2016-03-07 11:20:18 UTC
Created attachment 48734 [details] [review]
[3.22.x] Bug 15784: Library deletion warning is incorrectly styled

Patch for 3.22.x
Comment 9 Julian Maurice 2016-03-07 11:20:40 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 10 Frédéric Demians 2016-03-15 09:01:34 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.