Created attachment 49913 [details] [review] Bug 16203: item plugins (W-I-P) -rwxr-xr-x 1 master-koha master-koha 3082 Nov 19 10:04 barcode_manual.pl -rwxr-xr-x 1 master-koha master-koha 3896 Nov 19 10:04 barcode.pl -rwxr-xr-x 1 master-koha master-koha 4292 Nov 19 10:04 callnumber-KU.pl -rwxr-xr-x 1 master-koha master-koha 3406 Nov 19 10:04 callnumber.pl -rwxr-xr-x 1 master-koha master-koha 4424 Nov 19 10:04 cn_browser.pl -rwxr-xr-x 1 master-koha master-koha 2058 Nov 19 10:04 dateaccessioned.pl -rwxr-xr-x 1 master-koha master-koha 6777 Jan 4 10:34 macles.pl -rwxr-xr-x 1 master-koha master-koha 3409 Nov 19 10:04 stocknumberam123.pl -rwxr-xr-x 1 master-koha master-koha 3525 Nov 19 10:04 stocknumberAV.pl -rwxr-xr-x 1 master-koha master-koha 1646 Nov 19 10:04 stocknumber.pl Added license statement to cn_browser.pl.
Created attachment 50066 [details] [review] Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test.
Looks good, all plugins are working but QA tool says: FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
Thanks, Josef, for testing. You can safely ignore these warnings. They are not coming from the changes in this patch set, but from a (unmodified) module used by these plugins. This is the source: $ perl -cw C4/Barcodes/ValueBuilder.pm "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 43. "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 85. C4/Barcodes/ValueBuilder.pm syntax OK If you look at that module, you will see that it actually contains multiple packages and each one having a $DEBUG variable. A construction like that is not recommended and fortunately an exception in Koha, but it should work. The warning is actually dubious. All ready for a signoff ? :)
(In reply to Marcel de Rooy from comment #4) > > All ready for a signoff ? :) I think so ;)
Created attachment 57956 [details] [review] [SIGNED-OFF] Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Josef Moravec from comment #6) > Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Great! Thx.
FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
(In reply to Jonathan Druart from comment #8) > FAIL cataloguing/value_builder/barcode.pl > FAIL valid > "my" variable $DEBUG masks earlier declaration in same scope > > FAIL cataloguing/value_builder/barcode_manual.pl > FAIL valid > "my" variable $DEBUG masks earlier declaration in same scope Please read comment4. Back to SO
Created attachment 58185 [details] [review] Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #8) > > FAIL cataloguing/value_builder/barcode.pl > > FAIL valid > > "my" variable $DEBUG masks earlier declaration in same scope > > > > FAIL cataloguing/value_builder/barcode_manual.pl > > FAIL valid > > "my" variable $DEBUG masks earlier declaration in same scope > > Please read comment4. > Back to SO Sorry about that. Yes it's because we now "use" intead of "require". These DEBUG variables are completely useless and could be removed, but it's outside the scope of this bug.
Pushed to master for 17.05, thanks Marcel!
This won't get backported to 16.11.x as it is an enhancement.