Before Bug 16203, clicking the "..." plugin link on the item add form's date acquired field would insert today's date, overwriting an existing date if present. Now clicking the "..." link does nothing.
I think this is not a bug but a change in behavior. We have cataloging plugins with additional popups and those without such popups. The plugin for date acquired is in the last category. More technically, it has no launcher in its perl script. If you hover your mouse over the "plugin link", you will see "No popup". Iirc another report already mentioned the need for a clearer division. Imo no bug and no rel 17.11 candidate, but something to improve in style for 18.05.
Thanks for the clarification Marcel.
I consider this a bug BECAUSE it is a change in behavior. Functionality which my catalogers used daily has been removed, making their work more difficult.
(In reply to Marcel de Rooy from comment #1) > If you hover your mouse over the "plugin link", you will see "No popup". I see "Tag editor"
Created attachment 69082 [details] [review] Bug 19595: Clicking plugin link does not fill item's date acquired field This patch updates the dateaccessioned plugin for the item edit form to return functionality which was removed in a previous patch. To test, apply the patch and open an item for editing. Clicking the "..." link next to the "Date acquired" field should insert the current date, overwriting the existing date. Open a blank item add form. Putting the cursor in the "Date acquired" field should automatically insert the current date.
Created attachment 69085 [details] [review] Bug 19595: Clicking plugin link does not fill item's date acquired field This patch updates the dateaccessioned plugin for the item edit form to return functionality which was removed in a previous patch. To test, apply the patch and open an item for editing. Clicking the "..." link next to the "Date acquired" field should insert the current date, overwriting the existing date. Open a blank item add form. Putting the cursor in the "Date acquired" field should automatically insert the current date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a comment line in set_to_today.
(In reply to Jonathan Druart from comment #4) > (In reply to Marcel de Rooy from comment #1) > > If you hover your mouse over the "plugin link", you will see "No popup". > > I see "Tag editor" Caused by the presence of a Click event
(In reply to Owen Leonard from comment #3) > I consider this a bug BECAUSE it is a change in behavior. Functionality > which my catalogers used daily has been removed, making their work more > difficult. There is difficult and difficult :) Clicking in the field would have triggered the Focus event, but indeed it would not overwrite. But overwriting date acquired might not be a good idea most of the time ..
In view of its rather trivial nature, passing QA in one run.
*** Bug 19644 has been marked as a duplicate of this bug. ***
Pushed to master for 18.05, thanks to everybody involved!
Pushed to stable for 17.11.01, awesome work all!
Pushed to 17.05.x, will be in v17.05.07