Bug 16215 - Missing closing quote in checkout template
Summary: Missing closing quote in checkout template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/circ/circulation.pl?bor...
Keywords:
Depends on: 15821
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-06 14:30 UTC by Owen Leonard
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 16215 - Missing closing quote in checkout template (1.58 KB, patch)
2016-04-06 14:41 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED-OFF]Bug 16215: Missing closing quote in checkout template (1.63 KB, patch)
2016-04-06 15:56 UTC, Héctor Eduardo Castro Avalos 		Details | Diff | Splinter Review
Bug 16215: Missing closing quote in checkout template (1.69 KB, patch)
2016-04-06 16:46 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-06 14:30:11 UTC 
There is a missing closing quote in circulation.tt on line 411:

<button type="submit" class="deny"><i class="fa fa-times></i> Continue</button>
Comment 1 Owen Leonard 2016-04-06 14:41:26 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-06 15:56:47 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-06 16:46:35 UTC 
Created attachment 50001 [details] [review]
Bug 16215: Missing closing quote in checkout template

This patch adds a missing closing quote to the circulation template.

To see the affect of this bug:

- Log in to Koha with an account which does not have the
  'force_checkout' permission.
- Locate a barcode which is checked out to a patron.
- Open a different patron account for checkout.
- Try to check out the barcode to that different patron.

You see a "Cannot check out" dialog which breaks the structure of the
rest of the page.

To test, apply the patch and repeat the steps above. The issue should be
fixed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2016-04-06 22:02:10 UTC 
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-04-07 05:22:04 UTC 
Not needed in stable versions, status changed to RESOLVED