Use of uninitialized value $_[0] in string eq at /usr/share/perl5/JSON.pm line 159. malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "(end of string)") at t/OpenLibrarySearch.t line 25 # Looks like your test exited with 22 before it could output anything. t/OpenLibrarySearch.t ............... Dubious, test returned 22 (wstat 5632, 0x1600) Failed 1/1 subtests
Created attachment 52043 [details] [review] Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline
Created attachment 52068 [details] [review] [SIGNED-OFF] Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 52071 [details] [review] Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 52107 [details] [review] Bug 16649: Make OpenLibrarySearch test pass even if launches offline Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
3 signed-offs and trivial patch, skipping QA.
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.01.
Not needed in 3.22.x