http://openlibrary.org/dev/docs/api/read
Created attachment 46291 [details] [review] bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen.
Created attachment 46292 [details] [review] bug_6624: Added Open Library Search and Read API to openlibrary.js
Created attachment 46293 [details] [review] bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref
Created attachment 46655 [details] [review] bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 46656 [details] [review] bug_6624: Added Open Library Search and Read API to openlibrary.js Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 46657 [details] [review] bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Works as expected! I would say we might want to add a note down the road or some clue that the results will open in a new window unlike Overdrive - but that's not reason to not sign off on this. Nicole
Srdjan, koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 383 +++++++++++++++++++- This is wrong, opac.css should contain only 1 line and be generated from the less file. See https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files
Jonathan, that's exactly what I did. I'll give it another go, maybe did not get the options right
Created attachment 48152 [details] [review] bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Ok, so packaged lessc was not good, had to be installed with npm.
Created attachment 48159 [details] [review] bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48160 [details] [review] bug_6624: Added Open Library Search and Read API to openlibrary.js Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48161 [details] [review] bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48162 [details] [review] Bug 6624: Add test for OpenLibrary
Just curious, this test does not test any part of Koha. What if it fails?
(In reply to Srdjan Jankovic from comment #16) > Just curious, this test does not test any part of Koha. What if it fails? I was thinking of the tests we have for C4::XISBN, but I may be not relevant, feel free to obsolete it. If the test fails, the feature will be broken. It would mean that the key "numFound" or the url has changed.
s/I may/it may ...
OK, that makes sense. I was more thinking of tests auto run, and for some reason http request fails (site down, timeout etc) that raises red alert. But I'm probably taking it too far.
Pushed to Master - Should be in the May 2016 Release. Thanks