In the cataloguing form, the help links (question mark) for fields 590, 591, 592 etc. are broken. Such links should not point to http://www.loc.gov/marc/bibliographic/bd590.html but to http://www.loc.gov/marc/bibliographic/bd59x.html
Created attachment 95694 [details] [review] Bug 16683: Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages.
Created attachment 97549 [details] [review] Bug 16683: Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com>
Exactly as described.
Created attachment 97596 [details] [review] Bug 16683: Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
QA tests all show OK, except for nonnumeric error. Pushing to 19.11.x for 19.11.03
backported to 19.05.x for 19.05.08
Hi, Could this please be rebased for 18.11.x?
Created attachment 98940 [details] [review] Bug 16683: (18.11.x) Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages.