Can not find duplicated authorities cataloguing a new one, due to the new version of SimpleSearch
Created attachment 52440 [details] [review] Patch to solve this issue
1. Add a new authority that exists in your authority server, Koha will now find none. 2. Apply the patch 3. Add a new authority that exists in your authority server, Koha will find similar authorities in your catalogue
Comment on attachment 52440 [details] [review] Patch to solve this issue Review of attachment 52440 [details] [review]: ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ +829,4 @@ > } > } > my $searcher = Koha::SearchEngine::Search->new({index => $Koha::SearchEngine::AUTHORITIES_INDEX}); > + my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1, [ "authorityserver" ]); I don't think this is the correct solution, as ElasticSearch and Zebra both implement simple_search_compat, but ElasticSearch does not take the fourth parameter. Instead, it uses the objects 'index' accessor, which the Zebra version seems to be missing. Counter patch to follow today.
I have something which does this problem, but there seems to be a larger issue.
Created attachment 52869 [details] [review] Bug 16746: Proposed start of counter-patch This is the beginning of a counter patch. Feel free to apply it and test it, Juan Romay Sieira. However, please expand the test plan to be more detailed: -- type X into field Y -- click button Z -- click downdrop W -- select item V -- enter 'text' into text box labelled A "Add a new authority that exists in your authority server, Koha will now find none." is not detailed enough for a person unfamiliar with the interface. Feel free to apply 16809 first. :)
Created attachment 52870 [details] [review] Bug 16746: Proposed start of counter-patch This is the beginning of a counter patch. Feel free to apply it and test it, Juan Romay Sieira. However, please expand the test plan to be more detailed: -- type X into field Y -- click button Z -- click downdrop W -- select item V -- enter 'text' into text box labelled A "Add a new authority that exists in your authority server, Koha will now find none." is not detailed enough for a person unfamiliar with the interface. Feel free to apply 16809 first. :)
(In reply to M. Tompsett from comment #6) > Created attachment 52870 [details] [review] [review] > Bug 16746: Proposed start of counter-patch > > This is the beginning of a counter patch. > Feel free to apply it and test it, Juan Romay Sieira. > However, please expand the test plan to be more > detailed: > > -- type X into field Y > -- click button Z > -- click downdrop W > -- select item V > -- enter 'text' into text box labelled A > > "Add a new authority that exists in your > authority server, Koha will now find none." > is not detailed enough for a person unfamiliar with the > interface. > > Feel free to apply 16809 first. :) Are you going to continue on this?
*** This bug has been marked as a duplicate of bug 19415 ***