Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016): my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); The new call does unfortunately not include the authorityserver: my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 ); Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed. This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log: 16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout Patch forthcoming
Created attachment 67632 [details] [review] Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05 Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016): my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); The new call does unfortunately not include the authorityserver: my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 ); Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed. This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log: 16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout The fix is obviously trivial. Test plan: [1] Go to Authorities. [2] Add a new authority PERSO_NAME with 100a Moerenhout. [3] Repeat step 2. Verify that you get the duplicate authority warning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Marcel, It seems that other calls are affected too. Do not you think we should fix all of them on the same patch/bug?
(In reply to Jonathan Druart from comment #2) > Marcel, > It seems that other calls are affected too. Do not you think we should fix > all of them on the same patch/bug? If the calls are biblio related, it is no problem. Did you find specific authority calls ?
I though I found some (Koha/Authorities.pm), but they are biblio related indeed.
Created attachment 67788 [details] [review] Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05 Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016): my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); The new call does unfortunately not include the authorityserver: my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 ); Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed. This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log: 16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout The fix is obviously trivial. Test plan: [1] Go to Authorities. [2] Add a new authority PERSO_NAME with 100a Moerenhout. [3] Repeat step 2. Verify that you get the duplicate authority warning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 67846 [details] [review] Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05 Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016): my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); The new call does unfortunately not include the authorityserver: my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 ); Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed. This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log: 16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout The fix is obviously trivial. Test plan: [1] Go to Authorities. [2] Add a new authority PERSO_NAME with 100a Moerenhout. [3] Repeat step 2. Verify that you get the duplicate authority warning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
*** Bug 16746 has been marked as a duplicate of this bug. ***
Pushed to 16.05.x, for 16.05.19 release