$ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning.
Created attachment 53141 [details] [review] Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools
Created attachment 53167 [details] [review] [SIGNED-OFF]Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Workas as advertised
Created attachment 53186 [details] [review] Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Workas as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 53187 [details] [review] Bug 16860: Remove the comment about the warning It is no longer necessary. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Mark, Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10