When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it.
Created attachment 54784 [details] [review] Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied
Created attachment 54996 [details] [review] [SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
The value is no longer copied, but neither is the subfield code Example: I copy 260$b I get a new blank 260$_ (though the field description states "Name of publisher, distributor, etc" We should copy the subfield code but not the contents
Created attachment 55078 [details] [review] Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied
Created attachment 55079 [details] [review] Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied
Created attachment 55234 [details] [review] Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 55276 [details] [review] Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Hector!
Pushed in 16.05. Will be in 16.05.04.
Pushed to 3.22.x, will be in 3.22.11
Nick's comment still applies on master and 16.05. This patch broke subfield cloning. I opened bug 17477 with evidence of this.