Bug 17152 made the subfield cloning function delete the contents of the cloned subfield. But it makes the subfield tag empty too, and this is causing troubles for people re-opening the records for edition.
Created attachment 56697 [details] No subfield tag
Steps to reproduce: - On the cataloging screen, create a new record - Go to the 5xx fields - Put something on the 521$a subfield - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either.
Created attachment 56700 [details] [review] Bug 17477 - Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected
Created attachment 56704 [details] [review] Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 56722 [details] [review] Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 16.11, thanks Hector! Kyle
Pushed in 16.05. Will be in 16.05.05.
Pushed in 3.22.x, will be in 3.22.12