Created attachment 57529 [details] [review] Bug 17638: Flush the config cache on setting a new context
This patch fixes a big part of the tests, but some keep failing. I'd like someone to take a look, I am stuck with the other ones. It seems to be caused by bug 11921, but I don't manage to understand what's going wrong.
I'm not seeing any difference with "prove t/db_dependent/Search.t" with this patch than I do without. Am I testing the wrong file?
(In reply to Kyle M Hall from comment #3) > I'm not seeing any difference with "prove t/db_dependent/Search.t" with this > patch than I do without. Am I testing the wrong file? You should get less failures with this patch
(In reply to Jonathan Druart from comment #4) > (In reply to Kyle M Hall from comment #3) > > I'm not seeing any difference with "prove t/db_dependent/Search.t" with this > > patch than I do without. Am I testing the wrong file? > > You should get less failures with this patch Without patch: http://paste.koha-community.org/169 With patch: http://paste.koha-community.org/170 I'm not seeing a difference. That being said, it doesn't cause any problems either.
(In reply to Kyle M Hall from comment #5) > (In reply to Jonathan Druart from comment #4) > > (In reply to Kyle M Hall from comment #3) > > > I'm not seeing any difference with "prove t/db_dependent/Search.t" with this > > > patch than I do without. Am I testing the wrong file? > > > > You should get less failures with this patch > > Without patch: http://paste.koha-community.org/169 > With patch: http://paste.koha-community.org/170 > > I'm not seeing a difference. That being said, it doesn't cause any problems > either. For me it absolutely makes diferences On master: http://paste.koha-community.org/172 With this patch: http://paste.koha-community.org/173
(In reply to Josef Moravec from comment #6) > (In reply to Kyle M Hall from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > (In reply to Kyle M Hall from comment #3) > > > > I'm not seeing any difference with "prove t/db_dependent/Search.t" with this > > > > patch than I do without. Am I testing the wrong file? > > > > > > You should get less failures with this patch > > > > Without patch: http://paste.koha-community.org/169 > > With patch: http://paste.koha-community.org/170 > > > > I'm not seeing a difference. That being said, it doesn't cause any problems > > either. > > For me it absolutely makes diferences > On master: http://paste.koha-community.org/172 > With this patch: http://paste.koha-community.org/173 Yes, it's what I get.
Created attachment 57551 [details] [review] Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D
Created attachment 57552 [details] [review] Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D
Created attachment 57568 [details] [review] [SIGNED-OFF]Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly
Created attachment 57575 [details] [review] Bug 17638: Make sure t/db_dependent/Search.t doesn't use a cached koha-conf.xml This patch makes the tests clean the 'config' namespace for cache before it runs any tests. To test: - Run: $ prove t/db_dependent/Search.t => FAIL: Self explanatory - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: All green - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Cannot reproduce, but I trust everyone telling me it's failing ; ) No regressions spotted
Pushed to master for 16.11, thanks Tomas!
Pushed to 16.05.x, for 16.05.06 release