Run prove t/db_dependent/Search.t and there are non-zebra warnings which could be easily solved.
The use of caching in bug 17638 prevents the 'template' errors from occurring in master, but Koha::Cache is not in 16.05.x.
Created attachment 57686 [details] [review] Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t TEST PLAN --------- 0) back up database 1) drop database; create database 2) run web installer 3) prove t/db_dependent/Search.t -- notice spammy warnings (other than zebra index warnings) 4) apply patch 5) prove t/db_dependent/Search.t -- notice only zebra index warnings. 6) run qa test tools
Comment on attachment 57686 [details] [review] Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t Review of attachment 57686 [details] [review]: ----------------------------------------------------------------- ::: Koha/QueryParser/Driver/PQF/query_plan/node.pm @@ +49,4 @@ > foreach my $field (@{$self->fields}) { > $fieldobj = $self->plan->QueryParser->bib1_mapping_by_name('field', $self->classname, $field, $server); > $relbump = $self->plan->QueryParser->bib1_mapping_by_name('relevance_bump', $self->classname, $field, $server); > + if ($relbump && defined $relbump->{'attr_string'}) { This could be added to master, but I don't know how to trigger or test it. :)
Is this only for 16.05?
(In reply to Jonathan Druart from comment #4) > Is this only for 16.05? The comment #3 part still applies, I think to master. I just don't know how to trigger it. Changing to master and giving this back to the community to do.
Hi Can you please merge this patch with the current master as I get this merge error whilst applying 57686 - Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t Using index info to reconstruct a base tree... M t/db_dependent/Search.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Search.t CONFLICT (content): Merge conflict in t/db_dependent/Search.t Failed to merge in the changes. Patch failed at 0001 Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17664---Silence-non-zebra-warnings-in-tdbdepen-lNEMGe.patch
Created attachment 66431 [details] [review] Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t TEST PLAN --------- 0) back up database 1) drop database; create database 2) run web installer 3) prove t/db_dependent/Search.t -- the spammy warnings (other than zebra index warnings) may already be fixed, but the mocked value was not realistic. 4) apply patch 5) prove t/db_dependent/Search.t -- notice only zebra index warnings. 6) run qa test tools
Created attachment 67027 [details] [review] Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t TEST PLAN --------- 0) back up database 1) drop database; create database 2) run web installer 3) prove t/db_dependent/Search.t -- the spammy warnings (other than zebra index warnings) may already be fixed, but the mocked value was not realistic. 4) apply patch 5) prove t/db_dependent/Search.t -- notice only zebra index warnings. 6) run qa test tools Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 67665 [details] [review] Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t TEST PLAN --------- 0) back up database 1) drop database; create database 2) run web installer 3) prove t/db_dependent/Search.t -- the spammy warnings (other than zebra index warnings) may already be fixed, but the mocked value was not realistic. 4) apply patch 5) prove t/db_dependent/Search.t -- notice only zebra index warnings. 6) run qa test tools Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release