In order to be able to style the internal and public notes so they stand out more, it would be good if each of them had their own class. At the moment, there seems something not quite right, as both have an empty class="". To test: 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each
Created attachment 59053 [details] [review] bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there i
Created attachment 59054 [details] [review] bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed
Created attachment 59152 [details] [review] bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
There is a test just after, if true the "circ-hlt" class name will be used. I guess we want the 2 new classes in any cases. Marked as Failed QA.
Emma, you should also change the author's name of this patch.
Created attachment 59284 [details] [review] bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 59286 [details] [review] bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Created attachment 59503 [details] [review] [SIGNED-OFF] Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
But now the circ-hlt class name are removed. No idea if we must keep it or not. Any opinions?
Chris, do you know if this circ-hlt class is still useful?
Nope, they can safely be removed
Created attachment 60619 [details] [review] Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Emma!
This is marked enh, but as the classes being empty before can be considered a bug and the change is very small, I have decided to push this small one. This patch has been pushed to 16.11.x and will be in 16.11.05.
Pushed to 16.05.x, for 16.05.11 release