Bug 17919 - circ/returns.pl caught in Object Name crossfire
Summary: circ/returns.pl caught in Object Name crossfire
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on: 17466
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-17 06:30 UTC by Mark Tompsett
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17919: Koha::Issue is now called Koha::Checkout (1.42 KB, patch)
2017-01-17 06:38 UTC, Mark Tompsett 		Details | Diff | Splinter Review
Bug 17919: Koha::Issue is now called Koha::Checkout (1.47 KB, patch)
2017-01-17 07:30 UTC, Claire Gravely 		Details | Diff | Splinter Review
Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout (1.56 KB, patch)
2017-01-17 08:08 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2017-01-17 06:30:39 UTC 
Koha::Items was renamed to Koha::Checkouts
Find and fix any lingering code.
Only code? circ/returns.pl
Comment 1 Mark Tompsett 2017-01-17 06:38:31 UTC 
Created attachment 59059 [details] [review]
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t
Comment 2 Claire Gravely 2017-01-17 07:30:08 UTC 
Created attachment 59063 [details] [review]
Bug 17919: Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 3 Jonathan Druart 2017-01-17 08:08:55 UTC 
Created attachment 59068 [details] [review]
Bug 17919: (bug 17466 follow-up) Koha::Issue is now called Koha::Checkout

Ignoring the pluralization or lack thereof:
$ git grep "Koha::Issue"
-- This has results.
But this was renamed by 17796, and supposedly still
in discussion in 16870.

apply this patch, and do the same git.
There will be no results.

This was found while running a prove t/db_dependent/00-strict.t

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Kyle M Hall (khall) 2017-01-18 11:48:41 UTC 
Pushed to master for 17.05, thanks Mark!
Comment 5 Katrin Fischer 2017-01-22 16:51:52 UTC 
Depends on bug 17466 which is not in 16.11.x - won't be pushed.