Created attachment 56654 [details] [review] Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button
Created attachment 57806 [details] [review] Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button Signed-off-by: Radek Šiman <rbit@rbit.cz>
I am not sure a button is the right element to use here. Maybe a simple link is enough. CCing Owen to get his opinion.
I agree that a button isn't appropriate for what is acting as a link. I would suggest using a plain link, or using <a class="btn btn-mini btn-link"> which I think works well. Another comment: In the default translation we don't use the term "Issues" in this context. "Checkouts" is correct. https://wiki.koha-community.org/wiki/Terminology
Created attachment 58191 [details] [review] Bug 17466: Followup, change button to link and fix terminology
(In reply to Owen Leonard from comment #4) > I agree that a button isn't appropriate for what is acting as a link. I > would suggest using a plain link, or using <a class="btn btn-mini btn-link"> > which I think works well. > > Another comment: In the default translation we don't use the term "Issues" > in this context. "Checkouts" is correct. > > https://wiki.koha-community.org/wiki/Terminology Thanks Owen, I fixed it
Created attachment 58541 [details] [review] Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button Signed-off-by: Radek Šiman <rbit@rbit.cz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 58542 [details] [review] Bug 17466: Followup, change button to link and fix terminology Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 58543 [details] [review] Bug 17466 [QA Followup] - Give the link some style Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.05, thanks Josef!
This won't get ported back to 16.11.x as it is an enhancement.
Could not compile /home/vagrant/kohaclone/circ/returns.pl: Can't locate Koha/Issues.pm See bug 17919.