It looks like the Overdrive js and one of the Overdrive divs are being shown in the OPAC logged in user page when overdrive is disabled. This causes an error in the log, and displays a message on the logged in user screen where Overdrive is supposed to put whatever it's getting from the API. This is in the log: OverDriveClientKey pref not set at /home/vagrant/kohaclone/opac/svc/overdrive line 38.
I have a patch for this but I can't seem to attach it, seems the server is out of space.
Created attachment 60739 [details] [review] Bug 18172 - Disabled Overdrive shows error on logged in user page To test: Have overdrive disabled (default state) log into the OPAC (I did it with plack) note the error just below the tabs on the page. Note that the overdrive JS is being fetched/included Apply this patch Restart plack/memcached refresh the page, note that the error is gone. Also note that the JS for Overdrive is no longer being fetched/included.
Comment on attachment 60739 [details] [review] Bug 18172 - Disabled Overdrive shows error on logged in user page oops, something snuck in that shouldn't be there. Try again.
Created attachment 60740 [details] [review] Bug 18172 - Disabled Overdrive shows error on logged in user page To test: Have overdrive disabled (default state) log into the OPAC (I did it with plack) note the error just below the tabs on the page. Note that the overdrive JS is being fetched/included Apply this patch Restart plack/memcached refresh the page, note that the error is gone. Also note that the JS for Overdrive is no longer being fetched/included.
Sorry, patch does not apply (merge conflict in opac-user.tt).