Enable patrons to access their OverDrive account from Koha.
Requires WebService::ILS library from CPAN
Created attachment 48919 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler
Created attachment 48920 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services
Created attachment 48921 [details] [review] bug_16034 Add overdrive info to the users page in the public interface
I have not included a test plan for this. It cannot be tested without * an OverDrive account * return url of http(s)://your/opac/host/cgi-bin/koha/external/overdrive/auth.pl being registered with OverDrive In terms of regression testing, opac-user.tt has an additional tab that is visible only when OverDriveCirculation syspref is set to yes, so it should possibly be given just a quick check. If someone with an OverDrive account wants to have a go, please let me know and I will either email instructions or add them here.
Created attachment 49929 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 49930 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 49931 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Some preliminary questions: Did Jesse test with an OverDrive account? Noting such info in the signoff line could be helpful. You seem to be adding an optional dependency. I am missing PerlDependencies?
Yes, you must have an OverDrive account to use this, and even set up the return url with them. It's a process. I apologise, I did not update PerlDependencies, I thought it was only for mandatory deps. Do you want me to add it to the first patch, or write a follow-up?
(In reply to Srdjan Jankovic from comment #10) > Yes, you must have an OverDrive account to use this, and even set up the > return url with them. It's a process. I assumed so. But my question was: Did the signoffer (Jesse) actually test with an Overdrive account? > I apologise, I did not update PerlDependencies, I thought it was only for > mandatory deps. Do you want me to add it to the first patch, or write a > follow-up? Since you already have a SO, you'd better write a follow-up. No need to change status for that.
Created attachment 53793 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
I will confirm on Jesse's behalf, I believe they even implemented it.
Created attachment 55594 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Patch doesn't apply, please rebase. Would it be possible to get a test account in order to test this?
Created attachment 55675 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55676 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55677 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55678 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
If the rebase was not too complicated, putting back to "Signed off" is ok.
The rebase was easy, but the fourth patch (follow-up) was not signed-off earlier.
Created attachment 55763 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55764 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55765 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55766 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Created attachment 55815 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 55816 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Created attachment 57398 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 57399 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 57400 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 57401 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
couple things: POD fails QA tools opac/external/overdrive/auth.pl has wrong description (copy/paste error) When attempting to cancel a hold from results or patron details error is displayed at top of page: The title is not checked out. at /usr/local/share/perl/5.14.2/WebService/ILS/OverDrive/Patron.pm line 571. This is awesome overall though! Nice addition of ability to checkout/download/hold titles.
Created attachment 58518 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 58519 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 58520 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 58521 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Created attachment 58522 [details] [review] bug_16034 follow-up: Protect from unreliable OverDrive return API
I've fixed wrong descriptions in handlers. Unfortunately, I could not find a title that I could place a hold on. I've made a "blind"-ish change for returns, works for checked out items, so I'd imagine it would work with hold returns (cancellations). Can you please try it with this patch. Also, can you please let me know which title could be placed on hold so I can play with it.
I no longer get an error when cancelling a hold, but the hold is not cancelled either. 'Safe in his arms' is a title in the bywater library which can be placed on hold (In reply to Srdjan Jankovic from comment #38) > I've fixed wrong descriptions in handlers. > > Unfortunately, I could not find a title that I could place a hold on. I've > made a "blind"-ish change for returns, works for checked out items, so I'd > imagine it would work with hold returns (cancellations). Can you please try > it with this patch. Also, can you please let me know which title could be > placed on hold so I can play with it.
Created attachment 58790 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 58791 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Sorry Nick, was a bug. Fixed it.
Awesome, checking out and in and placing/cancelling a hold all work well now. When I click 'Logout from OverDrive account' the response seems to always be "Internal server error" can you check on that? POD still fails QA Additionally - two things would be nice: 1 - When you click to Sign In to OverDrive - this link should open in a new tab/window 2 - It would be nice to have a link to your overdrive account from the account page so that you can view the overdrive site if you wish to. (In reply to Srdjan Jankovic from comment #42) > Sorry Nick, was a bug. Fixed it.
Created attachment 59055 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59056 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59057 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59058 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Created attachment 59392 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59393 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59394 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59395 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
This is looking very good - the one issue I see remaining is the content in the OverDrive tab has a lot of html tags showing <i> <b> etc - can that be processed correctly? -Nick
Created attachment 59713 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Created attachment 59714 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies
Created attachment 59743 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 59744 [details] [review] bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 59745 [details] [review] bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 59746 [details] [review] Bug 16034 follow-up: added WebService::ILS to PerlDependencies Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Srdjan, Chris!
This won't get ported back to 16.11.x as it is an enhancement.
Comment on attachment 59743 [details] [review] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron Review of attachment 59743 [details] [review]: ----------------------------------------------------------------- ::: Koha/Schema/Result/Borrower.pm @@ +616,5 @@ > datetime_undef_if_invalid => 1, > is_nullable => 1, > }, > + "overdrive_auth_token", > + { data_type => "text", is_nullable => 1 }, This is terrible wrong, you have to commit the file generated by misc/devel/update_dbix_class_files.pl, with the sum updated! Now we are not able to regenerate the schema. DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/Borrower.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. Please fix ASAP
Created attachment 60626 [details] [review] Bug 16034 follow-up: generated Borrower resultset
Apologies, didn't know that. Now the patch contains much more than my field, hope it's fine.
Guys, another QA lesson :) if you add to borrowers, dont forget deletedborrowers DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on Koha::Schema::Result::Deletedborrower at /usr/share/koha/masterclone/Koha/Patron.pm line 416
Ee should have a test for that... it's gone wrong so many times now.
(In reply to Katrin Fischer from comment #65) > Ee should have a test for that... it's gone wrong so many times now. We have it already: % prove t/db_dependent/db_structure.t t/db_dependent/db_structure.t .. 1/? # Failed test 'tables related to Borrower and Deletedborrower should not differ on overdrive_auth_token.is_nullable' # at t/db_dependent/db_structure.t line 53. # got: '1' # expected: undef # Failed test 'tables related to Borrower and Deletedborrower should not differ on overdrive_auth_token.data_type' # at t/db_dependent/db_structure.t line 53. # got: 'text' # expected: undef # Looks like you failed 2 tests of 423. t/db_dependent/db_structure.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/423 subtests Test Summary Report ------------------- t/db_dependent/db_structure.t (Wstat: 512 Tests: 423 Failed: 2) Failed tests: 164-165 Non-zero exit status: 2 Files=1, Tests=423, 2 wallclock secs ( 0.06 usr 0.01 sys + 0.84 cusr 0.40 csys = 1.31 CPU) Result: FAIL
Comment on attachment 60626 [details] [review] Bug 16034 follow-up: generated Borrower resultset Too many wrong things in this patch, @RM do no push it and regenerate it yourself.
Created attachment 60654 [details] [review] Bug 16034: (followup) Fix DB update and schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Marcel de Rooy from comment #64) > Guys, > another QA lesson :) > if you add to borrowers, dont forget deletedborrowers > > DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on > Koha::Schema::Result::Deletedborrower at > /usr/share/koha/masterclone/Koha/Patron.pm line 416 In which case maybe a check in misc/devel/update_dbix_class_files.pl would be in order?
(In reply to Srdjan Jankovic from comment #69) > (In reply to Marcel de Rooy from comment #64) > > Guys, > > another QA lesson :) > > if you add to borrowers, dont forget deletedborrowers > > > > DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on > > Koha::Schema::Result::Deletedborrower at > > /usr/share/koha/masterclone/Koha/Patron.pm line 416 > > In which case maybe a check in misc/devel/update_dbix_class_files.pl would > be in order? There is a check in qa-tools
(In reply to Marcel de Rooy from comment #70) > (In reply to Srdjan Jankovic from comment #69) > > (In reply to Marcel de Rooy from comment #64) > > > Guys, > > > another QA lesson :) > > > if you add to borrowers, dont forget deletedborrowers > > > > > > DBIx::Class::Row::store_column(): No such column 'overdrive_auth_token' on > > > Koha::Schema::Result::Deletedborrower at > > > /usr/share/koha/masterclone/Koha/Patron.pm line 416 > > > > In which case maybe a check in misc/devel/update_dbix_class_files.pl would > > be in order? > > There is a check in qa-tools Nope, but we have a test, see comment 66.
This breaks master packages. There is no Debian package available. There is an ITP bug from Chris at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838609 I think this is optional, so maybe the test should be skippable (if that is a word)? # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 245. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' Makefile:22097: recipe for target 'test_dynamic' failed make[1]: *** [test_dynamic] Error 255 make[1]: Leaving directory '/tmp/buildd/koha-16.12.01~git+20170226133406.b5b4b708' dh_auto_test: make -j1 test returned exit code 2 debian/rules:9: recipe for target 'build' failed make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2
Is there a standard way we skip that kind of tests?
(In reply to Srdjan Jankovic from comment #73) > Is there a standard way we skip that kind of tests? We already kind of the same thing in C4::Members for the Norvegian specific ft. I guess thing like: use Module::Load::Conditional qw( can_load ); if ( ! can_load( modules => { 'WebService::ILS::OverDrive::Patron' => undef } ) ) { warn "Unable to load WebService::ILS::OverDrive::Patron"; } in place of the use statement would do the trick.
Created attachment 60789 [details] [review] Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
=head1 L<WebService::ILS::OverDrive::Patron> METHODS =item C<return($id)> sub return { Definitely a fine name for a method ;)
(In reply to Marcel de Rooy from comment #76) > =head1 L<WebService::ILS::OverDrive::Patron> METHODS > =item C<return($id)> > > sub return { > > Definitely a fine name for a method ;) Oh why cannot life be simple... I think it is safe, there are some rules and Perl knows which one's which. However, if it is making you uneasy, I can rename it to return_checkout() or something.
(In reply to Srdjan Jankovic from comment #77) > (In reply to Marcel de Rooy from comment #76) > > =head1 L<WebService::ILS::OverDrive::Patron> METHODS > > =item C<return($id)> > > > > sub return { > > > > Definitely a fine name for a method ;) > > Oh why cannot life be simple... I think it is safe, there are some rules and > Perl knows which one's which. However, if it is making you uneasy, I can > rename it to return_checkout() or something. No worries. But we should not use reserved words for methods, columns, etc. In another report we just removed a 'return' column from issues.. As you will understand, git grepping on return is laborious.
(In reply to Marcel de Rooy from comment #78) > > In another report we just removed a 'return' column from issues.. As you > will understand, git grepping on return is laborious. Ah right, of course, I had to do it myself when figuring out how difficult it would be to replace it. To my defence, I was grepping for "sub return" and "\->return".
I rolled a package and installed it. $ locate WebService/ILS/OverDrive/Patron.pm /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm Test fails anyway. # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/arch /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /tmp/buildd/koha-16.12+17311~git+20170309145207.123dfb1c/blib/PERL_MODULE_DIR/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive' # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 255.
Patch on comment 75 has not been pushed and package building fail, please open a new bug report and fix these issues ASAP.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Should we close this one then?
Comment on attachment 60789 [details] [review] Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing Attached to bug 18243
(In reply to Srdjan Jankovic from comment #82) > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 > > Should we close this one then? At least "pushed to master", not sure resolved is appropriate when there are known bugs. Did you also fix comment 80?
> Did you also fix comment 80? Not sure. I was not getting it in the first place. But 18234 should address that.
(In reply to Srdjan Jankovic from comment #86) > > Did you also fix comment 80? > > Not sure. I was not getting it in the first place. But 18234 should address > that. It's bug 18243 I guess. And no, it does not: % git bz apply 18243 % prove t/00-load.t # Failed test 'use Koha::ExternalContent::OverDrive;' # at t/00-load.t line 65. # Tried to use 'Koha::ExternalContent::OverDrive'. # Error: Can't locate WebService/ILS/OverDrive/Patron.pm in @INC (you may need to install the WebService::ILS::OverDrive::Patron module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl . /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins) at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # BEGIN failed--compilation aborted at /home/vagrant/kohaclone/Koha/ExternalContent/OverDrive.pm line 24. # Compilation failed in require at t/00-load.t line 65. # BEGIN failed--compilation aborted at t/00-load.t line 65. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::ExternalContent::OverDrive'
(In reply to Jonathan Druart from comment #87) > (In reply to Srdjan Jankovic from comment #86) > > > Did you also fix comment 80? > > > > Not sure. I was not getting it in the first place. But 18234 should address > > that. > > It's bug 18243 I guess. > > And no, it does not: > Omg, must have had it in my PERL5LIB. Submitted to 18243. Sorry.