Created attachment 60974 [details] [review] Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
Created attachment 61017 [details] [review] Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 61039 [details] [review] Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61055 [details] [review] Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes
Apologies for the late submission.
Created attachment 61063 [details] [review] Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61064 [details] [review] Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Ok thanks, skipping QA.
Fixes the problem for the nightly builds too, please push.
Pushed to master for 17.05, thanks Srdjan!
Depends on bug 16034 which is not in 16.11.x.