Failed checkouts on the sco can be triggered by presence of alert, however, we have no feedback for a successful checkout.
Created attachment 61040 [details] [review] Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out
Created attachment 61211 [details] [review] Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch>
Should not it be an id instead of a class?
And maybe the message should be in a box, to make it more visible. At the moment it is quite hidden.
(In reply to Jonathan Druart from comment #3) > Should not it be an id instead of a class? The alerts were introduced with Bug 11431, the triggers are in a class, e.g. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt_sec1 <div id="circ_needsconfirmation" class="dialog alert audio-alert-action">
Created attachment 61262 [details] [review] Bug 18251 (QA Followup) Add alert box to checkout message
I understand that your patch fixes your need, but to me it's now inconsistent. We get a confirmation message for checkouts, but for checkins... Do not you think we should get confirmation messages for all the sco possible actions?
(In reply to Jonathan Druart from comment #7) > Do not you think we should get confirmation messages for all the sco > possible actions? I do agree with this, we should give more feedback rather than less. Take this one as a start and open new bugs for other actions? Or would you prefer everything on one report?
I'd prefer to deal with everything here, the changes should not be big.
Created attachment 61324 [details] [review] Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts
Nick, I never see the "renewed" message. I am wondering if there is not something broken somewhere.
Created attachment 61343 [details] SCO renew button triggers a checkout (In reply to Jonathan Druart from comment #11) > Nick, I never see the "renewed" message. I am wondering if there is not > something broken somewhere. Looking at the form details for renewing I see 'checkout' in hidden field 'op', see screenshot attached. Would expect an op like 'renew'.
Created attachment 61665 [details] [review] Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout
In that case we could remove the confirmed param in the template, do you confirm? I can followup on QAing.
Created attachment 61715 [details] [review] Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61716 [details] [review] BUg 18251 (QA Followup) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61717 [details] [review] Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 61718 [details] [review] Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #14) > In that case we could remove the confirmed param in the template, do you > confirm? > I can followup on QAing. Wrong, we need it to avoid the call to CanBookBeIssued.
Hold on, do not push please.
Will need to be rebased on top of bug 18349.
Created attachment 66186 [details] [review] Bug 18251 - SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66187 [details] [review] BUg 18251 (QA Followup) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66188 [details] [review] Bug 18251 (QA Followup) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66189 [details] [review] Bug 18251 - (QA Followup) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
One pair of eyes is missing here.
I tried testing this, but ran into some problems: 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out I don't see the note in 9. Also renewals for me don't work. I tried to check out an item and immediately renew it. Nothing happens when I click on "renew item" - so I can't test this part. It's the same with and without the patch. Can someone confirm this?
Filed bug 19187 - figured out it was OpacRenewalAllowed. Renewals are ok (sound and note), but no sound and note for successful checkouts.
Created attachment 85409 [details] [review] Bug 18251: (follow-up) fix rebase error
Created attachment 85603 [details] [review] Bug 18251: SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85604 [details] [review] Bug 18251: (QA follow-up) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85605 [details] [review] Bug 18251: (QA follow-up) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85606 [details] [review] Bug 18251: (QA follow-up) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85607 [details] [review] Bug 18251: (follow-up) fix rebase error
I rebased the patchset as there were some minor conflicts. The patchset works as described, but I think it should be adapted to play internal sounds too.
(In reply to Josef Moravec from comment #35) > I rebased the patchset as there were some minor conflicts. The patchset > works as described, but I think it should be adapted to play internal sounds > too. I don't disagree with this, but I would consider it a separate issue. We will need to decide how we want to handle these. Copy all files to the opac directories? Build the full path to the intranet versions? Move the sounds to a new share directory? As there is some decision to be made I think we can do it on a new bug
(In reply to Nick Clemens from comment #36) > (In reply to Josef Moravec from comment #35) > > I rebased the patchset as there were some minor conflicts. The patchset > > works as described, but I think it should be adapted to play internal sounds > > too. > > I don't disagree with this, but I would consider it a separate issue. > > We will need to decide how we want to handle these. Copy all files to the > opac directories? Build the full path to the intranet versions? Move the > sounds to a new share directory? As there is some decision to be made I > think we can do it on a new bug I created new report, see bug 22406. As you pointed out, there are some decisions needed and we don't block this patchset with it. So I am returning this to the queue.
Created attachment 85616 [details] [review] Bug 18251: SCO alerts - need a trigger for successful checkouts This patch adds simple text and a div to allow for sounds to be configured upon successful SCO checkout To test: 1 - Enable sco module 2 - Enable AudioAlerts 3 - Define alert with Selector: .sco-alert-success Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg 4 - Checkout to patron using SCO 5 - Note only feedback is a addition of item to checkouts list 6 - Apply patch 7 - Checkout ot patron via SCO 8 - You should hear the sound specified above 9 - You should also see a note: Item checked out Followed test plan, works as expected. (Works with external sound only, see Bug 16732) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85617 [details] [review] Bug 18251: (QA follow-up) Add alert box to checkout message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85618 [details] [review] Bug 18251: (QA follow-up) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85619 [details] [review] Bug 18251: (QA follow-up) Add 'renew' operation and check renewal vs checkout Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85620 [details] [review] Bug 18251: (follow-up) fix rebase error Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Enhancement won't be backported to 18.11.x series.
This appears to contribute to the problem in Bug 26301...