Bug 22378 - Fix sound alerts on SCO
Summary: Fix sound alerts on SCO
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 18251 22441
  Show dependency tree / graph
 
Reported: 2019-02-20 19:59 UTC by Nick Clemens (kidclamp)
Modified: 2020-01-06 20:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 22378: Fix audio alerts on SCO (1.55 KB, patch)
2019-02-20 20:01 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 22378: Fix audio alerts on SCO (1.61 KB, patch)
2019-02-25 13:29 UTC, Josef Moravec 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2019-02-20 19:59:40 UTC 

    


    


      



        
          Comment 1
        

        
          Nick Clemens (kidclamp)

        

        
        

        
          2019-02-20 20:01:57 UTC
        

      






Created attachment 85410 [details] [review]
Bug 22378: Fix audio alerts on SCO

Note: The SCO only supports sounds with a full URL, not KOha built in sounds

To test:
1 - Enable audio alerts
2 -  Enable SCO
3 - Note JS error on loading the alerts
4 - Apply patch
5 - No more error
6 - Test with bug 18251

    


    


      



        
          Comment 2
        

        
          Josef Moravec

        

        
        

        
          2019-02-25 13:29:36 UTC
        

      






Created attachment 85615 [details] [review]
Bug 22378: Fix audio alerts on SCO

Note: The SCO only supports sounds with a full URL, not KOha built in sounds

To test:
1 - Enable audio alerts
2 -  Enable SCO
3 - Note JS error on loading the alerts
4 - Apply patch
5 - No more error
6 - Test with bug 18251

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

    


    


      



        
          Comment 3
        

        
          Nick Clemens (kidclamp)

        

        
        

        
          2019-02-26 13:18:05 UTC
        

      






Trivial, skipping QA

    


    


      



        
          Comment 4
        

        
          Nick Clemens (kidclamp)

        

        
        

        
          2019-02-26 14:41:07 UTC
        

      






Awesome work all!

Pushed to master for 19.05

    


    


      



        
          Comment 5
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2019-03-01 11:08:09 UTC
        

      






Pushed to 18.11.x for 18.11.04.

I'm sure we've broken this sort of thing a few times.. would have liked to have seen a selenium test for it...

    


    


      



        
          Comment 6
        

        
          Jesse Maseto

        

        
        

        
          2019-03-08 18:59:05 UTC
        

      






Patch doesn't apply cleanly. Please rebase if needed for 18.05.x.