t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method "cache_dir" via package "Swagger2::SchemaValidator" at /usr/share/perl5/Swagger2.pm line 42.
Created attachment 62817 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137)
Created attachment 62818 [details] [review] Bug 18508: Add overdrive_auth_token to patron.json definition To test: 1. prove t/db_dependent/api/v1/swagger/definitions.t
This is not testable without having various other libraries (mojolicious, etc. etc.) installed. Unable to test with old school git install Debian 8.
Fought my way through the installing, applied 18137, and then this. Before application, failure. After application, success.
Created attachment 62894 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 62895 [details] [review] Bug 18508: Add overdrive_auth_token to patron.json definition To test: 1. prove t/db_dependent/api/v1/swagger/definitions.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(In reply to M. Tompsett from comment #4) > Fought my way through the installing, applied 18137, and then this. Before > application, failure. After application, success. Thanks Mark!
(In reply to Lari Taskula from comment #0) > t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method > "cache_dir" via package "Swagger2::SchemaValidator" at > /usr/share/perl5/Swagger2.pm line 42. For the record, I was able to also solve this by upgrading Swagger2 (cpan2deb'ing it). However, this patch is the recommended way according to the noise it generates when you only apply 18763, if I recall correctly. For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures.
Comment on attachment 62895 [details] [review] Bug 18508: Add overdrive_auth_token to patron.json definition Bug 18763 fix this already.
Comment on attachment 62894 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) Review of attachment 62894 [details] [review]: ----------------------------------------------------------------- ::: t/db_dependent/api/v1/swagger/definitions.t @@ +23,4 @@ > use Test::Mojo; > > use Module::Load::Conditional; > +use JSON::Validator::OpenAPI; This only seems to be in Stretch.
Created attachment 65706 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 67232 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 6758) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 67265 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 18137) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 67266 [details] [review] Bug 18508: Fix t/db_dependent/api/v1/swagger/definitions.t (follow-up of 6758) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x