When membership is renewed, record the date of renewal in a new column "daterenewed".
Membership renewals are already logged by the BorrowersLog: '2530', '2015-05-25 14:03:55', '1', 'MEMBERS', 'RENEW', '1', 'Membership renewed' The date of the renewal is visible in the timestamp column.
It is far more efficient and far easier to have the column in the borrowers table than to join on the action logs for reporting purposes. I din't think this should be closed since Savitra specifically mentions a column for date renewed .
Created attachment 62696 [details] [review] Bug 6758 - Capture membership renewal date for reporting purposes
Created attachment 62697 [details] [review] Bug 6758 - Update Schema Files
Created attachment 62698 [details] [review] Bug 6758 - Add new patron column for date of renewal Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Create a new patron 4) Note the new column date_renewed is NULL 5) Renew the patron 6) Note the date in the column date_renewed is today's date
Created attachment 62699 [details] [review] Bug 6758 - Update Schema Files
Agreed. Thank you, Kyle!
Created attachment 62929 [details] [review] [SIGNED OFF] Bug 6758 - Add new patron column for date of renewal Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Create a new patron 4) Note the new column date_renewed is NULL 5) Renew the patron 6) Note the date in the column date_renewed is today's date Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Obsoleted patch with the Schema change as it no longer applied. Tested by regenerating the Schema files locally.
Created attachment 65490 [details] [review] Bug 6758: Add new patron column for date of renewal Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Create a new patron 4) Note the new column date_renewed is NULL 5) Renew the patron 6) Note the date in the column date_renewed is today's date Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 65491 [details] [review] Bug 6758: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 65492 [details] [review] Bug 6758: [QA Follow-up] Typo and field order In the borrowers table lang is added with 16.12.00.033 after lastseen and login_attempts is added with 16.12.00.037 after lastseen (so inserted BEFORE lang). This makes kohastructure.sql reflect that too in line with the DBIx schema changes. (Same for deletedborrowers.) Typo popular resolved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 67218 [details] [review] Bug 6758: Use 'is' instead of 'ok' in tests
Created attachment 67219 [details] [review] Bug 6758: [QA Follow-up] Typo popular vs populate Typo popular resolved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Marcel de Rooy from comment #12) > Created attachment 65492 [details] [review] [review] > Bug 6758: [QA Follow-up] Typo and field order > > In the borrowers table lang is added with 16.12.00.033 after lastseen and > login_attempts is added with 16.12.00.037 after lastseen (so inserted BEFORE > lang). This makes kohastructure.sql reflect that too in line with the > DBIx schema changes. (Same for deletedborrowers.) This patch must be on its own bug report, not related to these changes.
See bug 19344
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x