Created attachment 63155 [details] [review] Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT
Created attachment 63156 [details] [review] Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT Followed test plan, works as expected. Resolves issue with two print dialogues from Bug 18544. Signed-off-by: Marc Véron <veron@veron.ch>
Changing status to bug (minor) because of issue with print dialogues, see Bug 18544
*** Bug 18544 has been marked as a duplicate of this bug. ***
If I add two items to the cart, and I select them both by clicking All, and than deselect the first one, and than click Remove, all items are cleared from the cart. Failed QA
Created attachment 64158 [details] [review] Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart This patch makes a few corrections: - Use 'e.preventDefault()' instead of 'return false' in changed sections. - Modify the event handler on checkboxes to successfully handle the un-check action as well as the check action. (QA comment 5). To test, follow the original test plan.
Created attachment 64242 [details] [review] Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart This patch makes a few corrections: - Use 'e.preventDefault()' instead of 'return false' in changed sections. - Modify the event handler on checkboxes to successfully handle the un-check action as well as the check action. (QA comment 5). To test, follow the original test plan. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
I'm still seeing the same issue as Marcel.
(In reply to Kyle M Hall from comment #8) > I'm still seeing the same issue as Marcel. Sorry Kyle, I'm not seeing the issue after my last patch. Can someone else please test?
This patch works as described when applied. I'm going to sign off.
Created attachment 64861 [details] [review] Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 65172 [details] [review] Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT Followed test plan, works as expected. Resolves issue with two print dialogues from Bug 18544. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 65173 [details] [review] Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart This patch makes a few corrections: - Use 'e.preventDefault()' instead of 'return false' in changed sections. - Modify the event handler on checkboxes to successfully handle the un-check action as well as the check action. (QA comment 5). To test, follow the original test plan. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
All worked well for me, I could not recreate the issue Marcel and Kyle mentioned
Created attachment 65202 [details] [review] Bug 18545: Re-add call to enableCheckboxActions This call is used to refresh the page correctly
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.03.
These patches have been pushed to 16.11.x and will be in 16.11.11.
Pushed to 16.05.x, for 16.05.16 release