Opac cart has does not have a link "Empty and close", but no link or button for "Close". Would be nice to have one.
It's there, but it's hidden because of a collision with Bootstrap's CSS: <a class="hide close" href="opac-basket.pl">Hide window</a> The "hide" class makes it disappear :( I'm glad someone noticed because I didn't!
Created attachment 63777 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible.
Note: I did not touch the second toolbar (Select all, Clear all etc.) It has a problem as well: On a small screen, it is hidden (with and without this patch. Maybe the whole cart window needs a rewrite - but that is out of my scope.
Setting to NSO. If there is a better solution, I'll be happy to sign off on an alternative patch.
The "close" class on that link is what gives it its functionality. There's a globally-defined trigger for "windows.close()" on .close. Otherwise I think this is a good solution.
Created attachment 63854 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-30 mv)
Created attachment 63884 [details] [review] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv)
Created attachment 63885 [details] [review] [SIGNED-OFF] Bug 18546 - Unhide the 'Hide window' link in OPAC cart In OPAC cart, the link 'Hide window' is hidden because of a conflict with bootstrap css. This patch replaces the sprites for the toolbar with Fafamfam icons to make the 'Hide window' link visible. (Amended for comment #5 / 2017-05-31 mv) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Blocked by bug 18545?
(In reply to Jonathan Druart from comment #9) > Blocked by bug 18545? Bug 18545 is now pushed master, rebase this one ?
This solution does no longer work on top of Bug 18545 because the JavaScript is triggered by classes "brief", "detail" etc., and they display the original sprites / icons. As a result, we get two icons if we add the Famfamfam icons. For the original aim of this bug see comment #1
This looks to me to be fixed now.