Created attachment 64105 [details] [review]
Bug 18759: Try to fix random failure from Circulation.t

Circulation.t is failing randomly on our CI
https://jenkins.koha-community.org/job/Koha_Master_D8/192/console

    #   Failed test at t/db_dependent/Circulation.t line 1147.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1152.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1156.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1170.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1184.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 5 tests of 23.

Sometimes one of the alert or impossible flags is set.
This patch guesses that it's because of the 'restricted' value of the item that is evaluated to 1.
If it is not fixed by this patch, we will have more info next time (at least know
if alert or impossible is set).

Created attachment 64107 [details] [review]
Bug 18759: Try to fix random failure from Circulation.t

Circulation.t is failing randomly on our CI
https://jenkins.koha-community.org/job/Koha_Master_D8/192/console

    #   Failed test at t/db_dependent/Circulation.t line 1147.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1152.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1156.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1170.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1184.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 5 tests of 23.

Sometimes one of the alert or impossible flags is set.
This patch guesses that it's because of the 'restricted' value of the item that is evaluated to 1.
If it is not fixed by this patch, we will have more info next time (at least know
if alert or impossible is set).

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
The fix is trivial. Using random data will lead to this situations. The good thing is that
it lets us spot places in which tests need more fine-grained data.

Skipping QA, I would like to know quickly if it makes jenkins happy.

Patch pushed to master, thanks Tomas!

Without and with this patch:

t/db_dependent/Circulation.t (Wstat: 768 Tests: 95 Failed: 3)
  Failed tests:  90, 92, 94

(In reply to Marcel de Rooy from comment #5)
> Without and with this patch:
> 
> t/db_dependent/Circulation.t (Wstat: 768 Tests: 95 Failed: 3)
>   Failed tests:  90, 92, 94

Ha! How do you recreate?
Could you dump the %alerts and %impossible to know which keys are set?

From test 90:
print "L1148:".Dumper($error,$alerts);
L1148:$VAR1 = {
          'itemhomebranch' => 'KL7Eb',
          'ITEMNOTSAMEBRANCH' => 1
        };
$VAR2 = {};

print 'L1168:'.Dumper($question,$alerts);
L1168:$VAR1 = {
          'BORRNOTSAMEBRANCH' => 'jH5uvNo3ZN'
        };
$VAR2 = {};

L1179 $question $alerts
L1179:$VAR1 = {
          'BORRNOTSAMEBRANCH' => 'HZH'
        };
$VAR2 = {};

3 others similar
# Looks like you failed 6 tests of 26.

Subtest: CanBookBeIssued + Koha::Patron->is_debarred|has_overdues

Dumper($question,$alerts);
L1320:$VAR1 = {
          'BORRNOTSAMEBRANCH' => 'HV6N7TZ',
          'USERBLOCKEDOVERDUE' => 1
        };
$VAR2 = {};

# Looks like you failed 4 tests of 8.

Subtest: CanBookBeIssued + AllowMultipleIssuesOnABiblio

line 1488 error, alerts
$VAR1 = {
          'ITEMNOTSAMEBRANCH' => 1,
          'itemhomebranch' => 'bCP'
        };
$VAR2 = {};

etc.

# Looks like you failed 4 tests of 5.

Created attachment 64128 [details] [review]
Bug 18759: (follow-up) Try to fix random failure from Circulation.t

If IndependentBranches, CanBookBeRenewed will set ITEMNOTSAMEBRANCH
or BORRNOTSAMEBRANCH flags, if the branches do not match.

Marcel, your errors look different that ones from Jenkins.
Yours should be fixed with this patch (I recreated mocking IndependentBranches=1)

Last patch pushed to master!

Pushed to 17.05.x, will be in 17.05.01

This patch has been pushed to 16.11.x and will be in 16.11.09.

... patches even.

(In reply to Jonathan Druart from comment #11)
> Marcel, your errors look different that ones from Jenkins.
> Yours should be fixed with this patch (I recreated mocking
> IndependentBranches=1)
> 
> Last patch pushed to master!

Yeah. That was enough. Thx

Pushed to 16.05.x, for 16.05.15 release