Bug 18759 was supposed to fix random failures from Circulation.t but some tests can still fail randomly.
Created attachment 65357 [details] [review] Bug 19009: Fix random failures from Circulation.t From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass.
I still get one failure: t/db_dependent/Circulation.t .. 68/96 # Failed test 'days_in_advance is 7 in GetUpcomingDueIssues if not provided' # at t/db_dependent/Circulation.t line 894. # got: '3' # expected: '2'
I have never seen this one. Does it fail randomly? If not it should be fixed on another bug report, it's certainly data dependent.
Sorry, tester error.
Created attachment 65373 [details] [review] [SIGNED-OFF] Bug 19009: Fix random failures from Circulation.t From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
On top of 18802 it passes.
Created attachment 65506 [details] [review] Bug 19009: Fix random failures from Circulation.t From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 65507 [details] [review] Bug 19009: Fix random failures from Circulation.t From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
Dependency is not in 16.11.x (doesn't apply). Please take a look if you want this included.