The system preference SMSSendDriver doesn't mention the option to use Email in order to activate the feature for sending messages as sms using email gateways. See: http://bywatersolutions.com/2016/02/26/koha-sms/
Created attachment 70538 [details] [review] Bug 19179: Email option for SMSSendDriver is not documented as a valid setting 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if this message is at th end of the box:"If you would prefer to receive SMS via E-mail set SMSSendDriv
Created attachment 70539 [details] [review] Bug 19179: Email option for SMSSendDriver is not documented as a valid setting 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if this message is at th end of the box:"If you would prefer to receive SMS via E-mail set SMSSendDriver to E-mail "
Could you please rebase the patch, I tried to apply it and got a SHA1 error: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref). error: could not build fake ancestor. Thanks!
Created attachment 78498 [details] [review] Bug 19179: Email option for SMSSendDriver is not documented 'Email' is not documented as a valid setting. 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if SMSSendDriver has this message is at the end of the box: "If you would prefer to receive SMS via E-mail set SMSSendDriver to Email"
Created attachment 78504 [details] [review] Bug 19179: Email option for SMSSendDriver is not documented 'Email' is not documented as a valid setting. 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if SMSSendDriver has this message is at the end of the box: "If you would prefer to receive SMS via E-mail set SMSSendDriver to Email" Signed-off-by: Michal Denar <black23@gmail.coml>
Created attachment 78645 [details] [review] Bug 19179: Email option for SMSSendDriver is not documented 'Email' is not documented as a valid setting. 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if SMSSendDriver has this message is at the end of the box: "If you would prefer to receive SMS via E-mail set SMSSendDriver to Email" Signed-off-by: Michal Denar <black23@gmail.coml> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 78646 [details] [review] Bug 19179: (QA follow-up) Replace second E-mail Better write here exactly what we need to type in the pref text box. Since E-mail will not work and Email will :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.04
Pushed to 17.11.x for 17.11.10