Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email'
Created attachment 13290 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers
Created attachment 13291 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers [v3.08.03]
Created attachment 13293 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers
Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 13294 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers
I tested this today on the Sprint network and received the item checkout text message on my phone. Yay! This needs additional non-ByWater testing and signoff, please, preferably on a variety of mobile networks! Thanks, Melia
Just an aside, I confirmed this works with Verizon using vtext.com. In theory, we could pre-load useful sets of providers during the Koha's web-based setup phase. Kyle (In reply to comment #6) > I tested this today on the Sprint network and received the item checkout > text message on my phone. Yay! > > This needs additional non-ByWater testing and signoff, please, preferably on > a variety of mobile networks! > > Thanks, > > Melia
Created attachment 14166 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers - Followup
Created attachment 14167 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers
Just a comment after a quick look at the patch, there is a bad copy/paste: +DROP TABLE IF EXISTS sessions; +CREATE TABLE `sms_providers` (
Created attachment 14363 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers
Fixed! Thanks! (In reply to comment #10) > Just a comment after a quick look at the patch, there is a bad copy/paste: > > +DROP TABLE IF EXISTS sessions; > +CREATE TABLE `sms_providers` (
Created attachment 15685 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 15687 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 15689 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 15691 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Something went wrong ! Applying: Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Apply? [yn] Patch left in /tmp/Bug-9021---Add-SMS-via-email-as-an-alternative-to--IdzAav.patch
Created attachment 16628 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Kyle, Your last patch does not include new files (admin/sms_providers.[pl|tt]). Marked as Failed QA.
Created attachment 17311 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Applying: Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Using index info to reconstruct a base tree... M C4/Letters.pm M C4/Members.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt M members/memberentry.pl Falling back to patching base and 3-way merge... Auto-merging members/memberentry.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Members.pm CONFLICT (content): Merge conflict in C4/Members.pm Auto-merging C4/Letters.pm Patch failed at 0001 Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 21729 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Patch applied cleanly, go forth and signoff
Applying: Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Using index info to reconstruct a base tree... M C4/Letters.pm M C4/Members.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Members.pm CONFLICT (content): Merge conflict in C4/Members.pm Auto-merging C4/Letters.pm Patch failed at 0001 Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 22478 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Kyle, I'm curious about this development. Please forgive my ignorance on this, if this has already been discussed somewhere. Since the phone is utilizing an e-mail address already, why not just put the phone e-mail address in place of the e-mail address in the patron account, and have a setting next to the e-mail field to switch between standard and brief, where this setting would switch from the normal notice template to a shorter notice template. For example, instead of using the HOLD template, if brief is selected next to the e-mail field, then the HOLD (BRIEF) template would be used. Just a thought. Maybe I am missing something more complex? Christopher
Created attachment 28488 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Took the liberty to rebase against master 3.17.007. Works as advertised, but before I sign off, is it feasible to have the C4::Letters::_send_message_by_email respect the message_transport_type (sms) and then use the sms template in the generated notice?
Created attachment 29927 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
I just tried applying this patch and received the below errors. Hopefully it's an error on my end applying the patch. The Koha version that I was applying to is 3.17.00.027. ============================================================================== Applying: Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging members/memberentry.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/admin-home.pl CONFLICT (content): Merge conflict in admin/admin-home.pl Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers 29927 - Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-9021---Add-SMS-via-email-as-an-alternative-to--pOiIVH.patch
Created attachment 32453 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 34180 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 34181 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Didn't apply cleanly. Kyle can you rebase this. (it's just the updatedatabase.pl and structure ones. Should be pretty quick. I'd like to find someone to sign-off on this. Thanks, Brendan
Created attachment 35816 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Just when I figured out how to email to sms for my Canadian provider, the patch doesn't apply. :(
Created attachment 40720 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Could we get a back button that goes back to the administration screen from the SMS Provider entry screen?
(In reply to M. Tompsett from comment #38) > Could we get a back button that goes back to the administration screen from > the SMS Provider entry screen? I can, but I'm looking at all the administration areas and a not of them has such a link, so it seems like it would be breaking ui consistency to do so. There is a 'administration' link in the breadcrumbs that will take you back to the administration screen. Is that sufficient?
From IRC: library and groups, item types, AV new category, AV new AV, Patron attribute types, (strangely) library transfer limits, cities and towns, ... - cancel link. I could keep going, but the whole cancel link idea seems there. I don't think I'm getting it. However, I have no problem with you adding a followup to add the link.
Sorry, I was unclear. This UI is not consistent with other UIs already in Koha and was initially confusing to me. For example, the library and groups page is a data table with edit/delete on the rows, and a new library button which goes to a different template page to enter. That secondary page has a cancel link which goes back. Again, apologies for being half awake when trying to explain my issues. :)
Created attachment 44331 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Small conflict in a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt (from addition of audio alerts) Bigger issue, I can't get it to save the chosen SMS provider on the borrower screen
Created attachment 45152 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
I can't get SMS provider to save upon edit, and changing it through DB I didn't get the email
(In reply to Nick Clemens from comment #45) > I can't get SMS provider to save upon edit, and changing it through DB I > didn't get the email I can't reproduce your issue. Did you run updatedatabase.pl? Have you verified your server can send outgoing email successfully? Kyle
The issue is that the Koha/Schema/Result files are not automatically updated (so ModMember wasn't even looking to update the sms_rpovider_id column) , per discussion in koha irc: <pianohacker> What's the current procedure for patches that use Koha::Database on tables they introduce? Is the patch expected to include the new autogenerated files in Koha/Schema/Result, to ease testing? <cait> pianohacker: you can, but please in a separate patch <cait> easier when rebasing and easier for th etester, because they don't need to remember to run the script <pianohacker> cait: makes sense. <cait> and makes it sandbox testable
This reminds me of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567#c107: This was generated by: Reset hard to master. Restore old DB Apply the patches ... ./installer/data/mysql/updatedatabase.pl ./misc/devel/update_dbix_class_files.pl -db_name=... -db_user=... -db_passwd=... git add Koha/Schema/Results/...
Created attachment 46163 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute.
Created attachment 46164 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45.
Created attachment 46165 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45.
EnhancedMessagingPreferences! DOH! Test plans that assume person is completely naive are so much nicer.
Also, make sure there are SMS letters (notices and slips).
HA HA! Email configured well enough. Patch applies cleanly. I believe it tests well now. I'm signing off both, but since I wrote the Schema patch, I'd like another sign off.
Created attachment 46168 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools
Created attachment 46169 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46170 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46171 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
For Canadians using Rogers: Rogers phonenumber@pcs.rogers.com See step 5 in comment #4 for wider context.
Created attachment 47128 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 47129 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 47130 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 47133 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 47134 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 47135 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Given that some of these patches are mine, that is why it was Needs Signoff. Setting back.
Created attachment 47338 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 47339 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
My cellular provider does not provide this service, I am not able to test that the whole workflow works correctly. A few feedbacks anyway: 1/ It would be great to provide a Koha::Objects implementation for Koha::SMS::Provider 2/ SMSSendDriver is passed to the template in admin-home.pl, it's not necessary (use TT plugin instead) 3/ sms_providers.pl: use strict;use warnings; => use Modern::Perl; 4/ the ENGINE for the new table is not correct in the atomic update entry. 5/ You are create an index on a FK, it's not necessary: https://dev.mysql.com/doc/refman/5.7/en/create-table-foreign-keys.html Search for "Such an index is created on the referencing table automatically if it does not exist." 6/ When editing a patron, should not we hide the "sms provider" part if the sms number is not filled? 7/ When editing a provider, the selected line has a red background. We have the same behavior on smart-rules.pl and the background use is orange. It would make sense to have the same color. Marked as Failed QA for 2, 3, 4, 5 and 7
Created attachment 47814 [details] [review] Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script
Created attachment 47815 [details] [review] Bug 9021 [QA Followup] - Use Modern::Perl
Created attachment 47816 [details] [review] Bug 9021 [QA Followup] - Fix ENGINE, don't create index on FK
Created attachment 47817 [details] [review] Bug 9021 [QA Followup] - Use same color as circ rules editor for row highlighting
Created attachment 47818 [details] [review] Bug 9021 [QA Followup] - Switch to Koha::Object(s)
I get Can't use string ("Koha::SMS::Provider") as a HASH ref while "strict refs" in use at /home/koha/src/Koha/Object.pm line 248. on members/memberentry.pl You must also add the new DB column to deletedborrowers.
And a warning message should appear if you try to delete provider used by patrons.
Created attachment 47845 [details] [review] Bug 9021 [QA Followup] - Switch to Koha::Object(s)
Created attachment 47846 [details] [review] Bug 9021 - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used
Created attachment 47847 [details] [review] Bug 9021 [QA Followup] - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used
Created attachment 47848 [details] [review] Bug 9021 [QA Followup] - Add column to deleted borrowers, set null on provider deletion
Jonathan, I do believe these latest followups address all your concerns!
Kyle, please provide tests for the 2 new modules. See t/db_dependent/Koha/Cities.t for a generic example. You will need to cover the new patrons_using method as well.
Since I won't be able to test the whole workflow, I would prefer to either get a signoff on this new patchset or let another QAer continues with it.
(In reply to Jonathan Druart from comment #83) > Since I won't be able to test the whole workflow, I would prefer to either > get a signoff on this new patchset or let another QAer continues with it. I will work on the unit tests and try to find someone to re-sign this patch set.
Created attachment 47995 [details] [review] Bug 9021 [QA Followup] - Unit tests
Comment on attachment 47133 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Review of attachment 47133 [details] [review]: ----------------------------------------------------------------- ::: admin/sms_providers.pl @@ +41,5 @@ > + > +my $op = $cgi->param('op'); > +my $id = $cgi->param('id'); > +my $name = $cgi->param('name'); > +my $domain = $cgi->param('domain'); It might be an idea to add '// q{}' to the end of these.
Created attachment 48024 [details] [review] Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use.
Multi-commit bugs are a pain to get through. Thanks for the effort, Kyle. Applies cleanly. Affected test files run. Pretty color use. :) A nice simple elegance to the SMS Provider list. Thanks for the follow up about the additional message. I'll let QA argue over the exact wording. This works well!
Created attachment 48025 [details] [review] [SIGNED-OFF] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48026 [details] [review] [SIGNED-OFF] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48027 [details] [review] [SIGNED-OFF] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> NOTE: Rechecked Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48028 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48029 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Use Modern::Perl NOTE: Rechecked Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48030 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Fix ENGINE, don't create index on FK NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48031 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Use same color as circ rules editor for row highlighting NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48032 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Switch to Koha::Object(s) NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48033 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48034 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Add column to deleted borrowers, set null on provider deletion NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48035 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Unit tests NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48036 [details] [review] [SIGNED-OFF] Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. NOTE: Rechecked. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 48052 [details] [review] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber@provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber@messaging.sprintpcs.com Verizon phonenumber@vtext.com T-Mobile phonenumber@tmomail.net AT&T phonenumber@txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48053 [details] [review] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48054 [details] [review] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48055 [details] [review] Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48056 [details] [review] Bug 9021 [QA Followup] - Use Modern::Perl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48057 [details] [review] Bug 9021 [QA Followup] - Fix ENGINE, don't create index on FK Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48058 [details] [review] Bug 9021 [QA Followup] - Use same color as circ rules editor for row highlighting Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48059 [details] [review] Bug 9021 [QA Followup] - Switch to Koha::Object(s) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48060 [details] [review] Bug 9021 [QA Followup] - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48061 [details] [review] Bug 9021 [QA Followup] - Add column to deleted borrowers, set null on provider deletion Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48062 [details] [review] Bug 9021 [QA Followup] - Unit tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48063 [details] [review] Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48064 [details] [review] Bug 9021: Fix conflict with bug 15446 (type vs _type) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48065 [details] [review] Bug 9021: Save the provider even if the sms number is not modified Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 48066 [details] [review] Bug 9021: Save the provider even if the sms number is not modified Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 3.24 release!
(In reply to Kyle M Hall from comment #116) > Pushed to Master - Should be in the May 2016 3.24 release! Enhancement, skipping for 16.05.x
(In reply to Mason James from comment #117) > (In reply to Kyle M Hall from comment #116) > > Pushed to Master - Should be in the May 2016 3.24 release! > > Enhancement, skipping for 16.05.x oups, patchset is already added to 16.5.x :0)