In acquisitions, when adding items to basket from an external source there is an option to select MARC framework. No matter what we choose, the record is created in default framework.
Caused by bug 15801.
Created attachment 67398 [details] [review] Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used
Upping severity a bit as it impacts stable releases.
Patch tested with a sandbox, by Marijana Glavica <mglavica@ffzg.hr>
Created attachment 67429 [details] [review] Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Created attachment 67430 [details] [review] Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Sorry, I am not sure how this duplicate testing and signing-off has happened.
Created attachment 67443 [details] [review] Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.05.
This patch has been pushed to 16.11.x and will be in 16.11.13.