Bug 35927 - Selecting MARC framework again doesn't work when adding to basket from an external source
Summary: Selecting MARC framework again doesn't work when adding to basket from an ext...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 19372
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-29 09:50 UTC by Fridolin Somers
Modified: 2024-05-30 19:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12


Attachments
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source (3.39 KB, patch)
2024-01-29 09:55 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source (3.58 KB, patch)
2024-02-27 08:06 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source (3.67 KB, patch)
2024-05-10 13:14 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-01-29 09:50:59 UTC
Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source.
Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.
Looks like it comes from a bad syntaxe than needs to be replaced in any case.
Comment 1 Fridolin Somers 2024-01-29 09:55:15 UTC
Created attachment 161576 [details] [review]
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source

Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source.
Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.
Looks like it comes from a bad syntaxe than needs to be replaced in any case.

Test plan:
1) Add an order to a basket from an external source
2) Select another framework than the default one
3) Chek the framework code you will pick will be used in the created biblio record
Comment 2 David Nind 2024-02-06 17:52:10 UTC
I'm not seeing this on the current master. Are there any additional steps I need to do?

Happy to sign off if this is aimed at improving the code and no change in behavour.

Or should I test using Ubuntu Focal as the operating system?

How I tested:
1. Go to Acquisitions, then click 'Search'.
2. Select 'My Basket' > Add to basket > From an external source.
3. In the 'Order from external source' form:
   - Title: DITA best practices
   - Select MARC framework: select another framework, such as 'Books. Booklets, Workbooks'
4. For actions, select +Order.
5. Complete the required fields and click 'Add item'.
6. Complete the accounting details form and click 'Save'.
7. Edit the newly created record.
8. Under the Settings menu, the framework should be the same as you selected in step 3.

Note: If I repeat and add the same record again (for duplicate warning: create new record), the new record shows as the default framework. (I'm not sure why you would do this, but it is possible to. The patch doesn't fix this.)
Comment 3 Victor Grousset/tuxayo 2024-02-26 07:14:24 UTC
Can't reproduce on a Ubuntu 20.04 ktd. tested on marc21 and unimarc an picked an appropriate external server source for each.

Each time on the record, I got the framework that I picked in the search result view.

---

Fridolin:
> Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.

Did you mean "I can't reproduce" ?

---

David:
> Happy to sign off if this is aimed at improving the code and no change in behavour.

Tested with patches on Ubuntu 20.04 with unimarc.
At least no sign of regression indeed.

@Fridolin: was this patch tested on the instance that had the issue?


Back to assignee to avoid having more people try to test while a way is found to reproduce. And if not, we say that it's a hardening patch and testing is just needed to see that there is no obvious regression.
Comment 4 Fridolin Somers 2024-02-26 14:44:48 UTC
Indeed, "I can't reproduce" on ktd

Indeed the patch is tested on the instance that had the issue?

Ah it is a Debian Stretch I see.
Comment 5 Victor Grousset/tuxayo 2024-02-27 07:59:52 UTC
Oh no, it's Debian 9 and it's not supported anymore :o

After many attempts, here is how to start an old image:

# Somehow it needs elasticsearch, here opensearch works fine
KOHA_IMAGE=22.05-stretch bin/ktd --os1 up
# It works with the master branch of KTD repo
# After trying, older branches don't help to simplify the operation.

# and **while** it's starting go into the container and edit the repositories
vim /etc/apt/sources.list

# replace "httpredir" with "archive" and removed the 2nd line.
# In the end the content should be
```
deb http://archive.debian.org/debian stretch main
```
# otherwise it will 404 when trying to install the cpanoutdated package and crash
Comment 6 Victor Grousset/tuxayo 2024-02-27 08:06:12 UTC
Created attachment 162487 [details] [review]
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source

Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source.
Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.
Looks like it comes from a bad syntaxe than needs to be replaced in any case.

Test plan:
1) Add an order to a basket from an external source
2) Select another framework than the default one on the search result
   view. Before doing 'add order' on choosen search result line.
3) Chek the framework code you will pick will be used in the created biblio record

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2024-02-27 08:08:18 UTC
> After many attempts, here is how to start an old image:

(and Koha's code should be on 22.05.x)

And all this to no even reproduce the bug T_T

Anyway, let's go with David's suggestion to sign-off that there is no visible regression. As it fixed the bug on your production instance.
Comment 8 Nick Clemens (kidclamp) 2024-04-01 15:15:49 UTC
If I understand here, this is a 22.05 bug? I updated the version on this report
Comment 9 Victor Grousset/tuxayo 2024-04-16 02:34:10 UTC
> this is a 22.05 bug?

No, it's just that one must go back to 22.05 to start a Debian 9, I tried that in case that was needed to reproduce.
Comment 10 Nick Clemens (kidclamp) 2024-05-10 13:14:48 UTC
Created attachment 166555 [details] [review]
Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source

Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source.
Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install.
Looks like it comes from a bad syntaxe than needs to be replaced in any case.

Test plan:
1) Add an order to a basket from an external source
2) Select another framework than the default one on the search result
   view. Before doing 'add order' on choosen search result line.
3) Chek the framework code you will pick will be used in the created biblio record

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Katrin Fischer 2024-05-10 15:47:02 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 12 Fridolin Somers 2024-05-29 09:22:22 UTC
Pushed to 23.11.x for 23.11.06
Comment 13 Lucas Gass 2024-05-30 19:12:12 UTC
Backported to 23.05.x for upcoming 23.05.12