Are there instructions somewhere on how to set up the Selenium environment necessary for testing the attached patches?
Alex wrote a complete test plan in all the commit messages.
I looked at them, but was not sure what to make of this: 4. Ensure you have your selenium service running
My fault, I should have read further, the first test plan I looked at didn't include it, but the last version of the commit message had full instructions: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974#c8
About: bug 18974 bug 19182 bug 19183 bug 19184 bug 19189 > The tests need to be rewritten completely. What would be needed to be rewritten? The test business logic or the usage of the test stack? Is there an existing test that I could use as a model for the current good practices? Then I'll try to implement one of the above tests.
Look at the patches on these bug reports, then compare with what we have in t/db_dependent/selenium. Alex wrote the patches before the code has been moved to a t::lib::Selenium module (bug 19802 and bug 19243 were the start). The logic is correct, but the paths are too specific (maybe generated with a tool) which makes the maintainability very hard. The methods from the t::lib::Selenium should be used as much as possible (auth, click, fill_form, submit_form). I think administration_tasks.t is a good example to follow.
> but the paths are too specific (maybe generated with a tool) Let me check. > ($driver->find_element_by_xpath('/html/body/div/div[4]/div/div/div[2]/div/div[2]/div[2]/form[1]/div/table/tbody/tr/td[6]/span[1]')) { Indeed, that's totally like a browser plugin recorded the action of the user. These are valuables tools if a project has the processes and people to handle, check and fix the false positive breakages. Thanks for the pointed, I'll take a look at these.
*pointers