Because of bug 22895 we now need those tests ASAP.
Created attachment 89673 [details] [review] Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success
Created attachment 90208 [details] [review] Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
> You can also test the buggy branch: Applying this patch on v18.11.05 conflicts. I think I might be able to backport it, is it worth it?
this patch: 22898, the new tests
Created attachment 90241 [details] [review] Bug 22898: [v18.11.05] Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success
New patch for 18.11.05, unfortunately I was not able to test it (firefox-esr version mismatch in kohadevbox)
(In reply to Victor Grousset/tuxayo from comment #3) > > You can also test the buggy branch: > > Applying this patch on v18.11.05 conflicts. > I think I might be able to backport it, is it worth it? Always good to have more tests :)
I've got a little lost.. what's the state of these.. do they need testing independently on both 18.11.x and master at this point?
(In reply to Martin Renvoize from comment #8) > I've got a little lost.. what's the state of these.. do they need testing > independently on both 18.11.x and master at this point? 18.05.x patch was to recreate the failure, see test plan.
This needs updating for current master.. the tests currently fail.
Created attachment 97655 [details] [review] Bug 22898: Since bug 23957, submit element is now a button (no longer input)
Created attachment 97656 [details] [review] Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now.
Needs a rebase for the circ rules work.
Created attachment 98877 [details] [review] Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>
Created attachment 98878 [details] [review] Bug 22898: Since bug 23957, submit element is now a button (no longer input)
Created attachment 98879 [details] [review] Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now.
I skip the 18.11 patch. New test plan: Make sure the tests pass.
Created attachment 98880 [details] [review] Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 98881 [details] [review] Bug 22898: Since bug 23957, submit element is now a button (no longer input) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 98882 [details] [review] Bug 22898: Fix failure since bug 19618 See comment in the code, this is not the correct fix, but cannot find something better for now. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
We're better off with these tests than without.. they are all currently passing and read ok.. Passing QA
Nice work everyone! Pushed to master for 20.05
does not apply to 19.11.x branch