To reproduce 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly
Created attachment 67541 [details] [review] Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT
Academy: Requires that you order and receive something first, but easy to test if you already have some acq data.
Created attachment 67794 [details] [review] Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi Aleisha, this works nicely! I have filed another bug report for the invoice search page that is also missing the confirmation message: bug 19429
Created attachment 70025 [details] [review] Bug 19401: Add confirm message when deleting invoice To test: 1) Go to Acquisitions 2) Go to Invoices (left nav menu) 3) Click Search (no need to filter results) 4) Click dropdown menu for an invoice, click Details 5) Click Delete 6) Notice invoice is deleted instantly 7) Apply patch and repeat steps 4 and 5 8) Confirm the confirm message shows and works as expected Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Owen, what would be the best pattern to follow here? I think id="delete" is not specific enough, it should be id="delete_invoice" id or class? See bug 19429.
I think "delete_invoice" is better, but it's more a matter of style than functionality. ids should always be unique, so if we're validating the markup as we go we'll be warned about duplicates. On this page an id is the right choice over a class because it will always be a unique element. In Bug 19429 it must be a class because the element repeats for each invoice in the table which can be deleted.
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all, pushed to stable for 17.11.02
Pushed to 17.05.x for v17.05.09