In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the acquisitions templates.
Created attachment 69532 [details] [review] Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable
Created attachment 69795 [details] [review] Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 70081 [details] [review] Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70082 [details] [review] Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Please rebase on top of bug 19401.
Created attachment 70123 [details] [review] Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70124 [details] [review] Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70128 [details] [review] Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70129 [details] [review] Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 70130 [details] [review] Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, skipping for 17.11.x. Awesome work everybody!