This bug will group several patches to make all strings translatable in the Label creator tool (those that I've found at least)
Created attachment 68471 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print"
More patches to come. The first one can already be signed off to check the process and content.
Created attachment 68472 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Works wonders ! Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68526 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" and remove the fuzzy flag 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print"
Created attachment 68527 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch
Created attachment 68537 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see "foobar" instead of "Fields to print" 8. then you should see the "Unités" dropdown with french units
Created attachment 68538 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form
Comment on attachment 68526 [details] [review] Bug 19522: Label creator - some strings are not translatable git-bz invalidated this patch because another one had the same commit summary (which was the name of this bug)
Created attachment 68612 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" and remove the fuzzy flag 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print"
Created attachment 68613 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch
Created attachment 68614 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units
Created attachment 68615 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form
Created attachment 68616 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ."
Created attachment 68674 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. refresh the page 8. then you should see "Cote" in the column names
Created attachment 68739 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names
Created attachment 68740 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes"
Doesn't seem to work. Maybe the translated string is only present in your .po? You can take a look at the screenshot I took : fr-FR.png
Created attachment 68785 [details] the string failed to be translated...
Thanks for testing my first set of patches. > Maybe the translated string is only present in your .po? The .po I use is the one from the repository without any modification. I followed the test plan for 68740 from the latest code on the master branch. And whether by applying only 68740 or all the patches. In the end, I get the expected result ("Exporter des étiquettes"). I'm not sure my step 9 was well named (one might think that it's different from step 1) It means using `koha-translate --install` or `./translate install` is that what you did?
I installed fr-FR in my devbox using 'sudo koha-translate --install fr-FR --dev kohadev' With the patch applied, even after running 'sudo koha-translate --update fr-FR --dev kohadev' I still don't see 'Fields to print' as a standalone string in the po file.
@Owen Leonard I followed the test plan for 68612 from the latest code on the master branch. And applied only 68612. After step 6 (update the language, I used ./translate update fr-FR) When I run grep -rin -E "\"fields to print" misc/translator/po Then I get misc/translator/po/fr-FR-staff-prog.po:24391:msgid "Fields to print"
Could there be a difference between using koha-translate and misc/translator/translate?
Hm there could be. Owen, could you try from koha-shell with cd misc/translator perl translate update fr-FR ?
@Owen it seems that koha-translate doesn't work on a dev install. http://irc.koha-community.org/koha/2017-11-03#i_1985535 @Dominic how did you installed the language? https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client#Installing_translations
i translated using misc/translator/translate fr-CA
Created attachment 68964 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68965 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" and remove the fuzzy flag 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print" Signed-off-by: Your Name <you@example.org>
Created attachment 68966 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Your Name <you@example.org>
Created attachment 68967 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Your Name <you@example.org>
Created attachment 68968 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Your Name <you@example.org>
Created attachment 68969 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Your Name <you@example.org>
Created attachment 68970 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Your Name <you@example.org>
Created attachment 68971 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Your Name <you@example.org>
Created attachment 68973 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" and remove the fuzzy flag 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68974 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68975 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68976 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68977 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68978 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 68979 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 70015 [details] [review] Bug 19522: Label creator - some strings are not translatable Add missing case to make "Fields to print" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout 3. ensure that the list isn't empty 4. then you should see "Fields to print" in the table header 5. apply this patch 6. update the language 7. open misc/translator/po/fr-FR-staff-prog.po 8. translate the new string with something like "foobar" and remove the fuzzy flag 9. install the language 10. refresh the page 11. then you should see "foobar" instead of "Fields to print" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70016 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70017 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70018 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70019 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70020 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70021 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt).
Created attachment 70449 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70450 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70451 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70452 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70453 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 70454 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Jonathan Druart from comment #48) > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt). I resolved the conflict in this file. The strange thing is that there didn't seem to be a conflict. A git diff between my previous local branch for this bug and a new one (used for the conflict resolution) showed nothing on the involved file. But the patches successfully apply now.
Created attachment 70935 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70936 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70937 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70938 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70939 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70940 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Do we need it in patroncards/manage.tt as well?
(In reply to Jonathan Druart from comment #62) > Do we need it in patroncards/manage.tt as well? Created and took bug 20111 for that.
(In reply to Victor Grousset/tuxayo from comment #63) > (In reply to Jonathan Druart from comment #62) > > Do we need it in patroncards/manage.tt as well? > > Created and took bug 20111 for that. I am waiting for it to push these ones.
There's one more GB_showCenter (in labels/label-manage.tt) that needs the translation function
Created attachment 72357 [details] [review] Bug 19522: Label creator: Batches: make "Export Labels" translatable
Thanks paxed, I noticed this string but though that I wasn't translatable due to the Grey Box lib.
Created attachment 72371 [details] [review] Bug 19522: Label creator: Batches: make "Export Labels" translatable
Created attachment 72375 [details] [review] Bug 19522: Label creator: Batches: make "Export Labels" translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 72415 [details] [review] Bug 19522: i18n Label creator: wrap text with <span> In a SWITCH CASE. To avoid pollution and duplication in the .po files.
Created attachment 73228 [details] [review] Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73229 [details] [review] Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73230 [details] [review] Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73231 [details] [review] Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "créer un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "créer un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73232 [details] [review] Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73233 [details] [review] Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des étiquettes" Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73234 [details] [review] Bug 19522: Label creator: Batches: make "Export Labels" translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 73235 [details] [review] Bug 19522: i18n Label creator: wrap text with <span> In a SWITCH CASE. To avoid pollution and duplication in the .po files. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!