Hopefully at least 80% of the fixes and 70% of the test plan of bug 19522 will be reusable.
Created attachment 71603 [details] [review] Bug 20111: Coding style: Fix indentation before doing actual change
Created attachment 71604 [details] [review] Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units
Actually the Patron card creator didn't lack as much i18n as the Label creator. I was fooled by the french translations not being complete in master when they were in Pootle. ^^
We should surround these strings with a HTML tag (span?) to avoid TT directives in the po files (please apply the fix to both .tt)
(In reply to Jonathan Druart from comment #4) > (please apply the fix to both .tt) There is one .tt in this bug. Did you mean bug 19522?
Created attachment 72409 [details] [review] Bug 20111: i18n Patron card creator: wrap with <span> To avoid pollution and duplication in the .po files.
Created attachment 72410 [details] [review] Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units
(In reply to Jonathan Druart from comment #4) > We should surround these strings with a HTML tag (span?) to avoid TT > directives in the po files (please apply the fix to both .tt) Done in this bug. Initially in a separate patch but then the two patches were squashed.
Created attachment 73146 [details] [review] Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73147 [details] [review] Bug 20111: Coding style: Fix indentation before doing actual change Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73148 [details] [review] Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73236 [details] [review] Bug 20111: Coding style: Fix indentation before doing actual change Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73237 [details] [review] Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!