In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the MARC-related administration templates.
Created attachment 69042 [details] [review] Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc.
Created attachment 69049 [details] [review] Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Created attachment 69496 [details] [review] Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment for RM: After this patch the bold emphasizing of some items in admin menu will be broken until these bugs are pushed: bug 19600 bug 19601 bug 19607 bug 19608 bug 19603
I will need this to be based on top of bug 10306.
Created attachment 69572 [details] [review] Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Skipping for 17.11, enhancement